pause scope: don't use the global math/rand RNG

[vrothberg]

Otherwise, we'll always get the same sequence of random numbers which
may lead to conflicts. Also bump the number of maximum attempts to 10
instead of 3.

[NO NEW TESTS NEEDED] as I cannot enforce random number collisions.
Existing tests should continue be green and flake slightly less.

Signed-off-by: Valentin Rothberg [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[vrothberg]

@containers/podman-maintainers PTAL

[mheon]

/lgtm
/hold

[vrothberg]

/hold cancel

[Luap99]

Sorry but that looks dangerous to me, reinitializing the random seed every time the function is called can also cause conflicts. When two callers call the function at the exact same time they will end up with the same random value.
Why not just use crypt/rand package instead?

[vrothberg]

Sorry but that looks dangerous to me, reinitializing the random seed every time the function is called can also cause conflicts. When two callers call the function at the exact same time they will end up with the same random value. Why not just use crypt/rand package instead?

We recently had updates to use a time-based seed as in this PR, so I used it. What's the benefit of crypt/rand?

[Luap99]

You do not have to seed crypt/rand it uses getrandom(2), see https://pkg.go.dev/crypto/rand

[vrothberg]

Interesting! Mind opening a PR?

[Luap99]

Sure

[Luap99]

PR #12610