Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create --init-ctr once: flake: occasionally seems to actually (and incorrectly) run #11682

Closed
edsantiago opened this issue Sep 21, 2021 · 15 comments
Assignees
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

This is a weird one. Only two occurrences (four, if you count retries within the same PR):

           podman make sure once container is removed
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_initcontainers_test.go:101
         
         [BeforeEach] Podman init containers
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_initcontainers_test.go:22
         [It] podman make sure once container is removed
           /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_initcontainers_test.go:101
         Running: podman [options] create --init-ctr once --pod new:foobar quay.io/libpod/alpine:latest bin/sh -c echo RvmaTMZpEbGBRJfg > /dev/shm/stbkBXTERreu
         21d775a67a44bb9deee0d5895f7bcfaa8bfd553847d68f7c87895c9bea2861b6
         Running: podman [options] create --pod foobar -t quay.io/libpod/alpine:latest top
         c0b94e4017e4766be71b2f22ee9a11ab2d8e7a82503c6d8d4f43b39ce1430386
         Running: podman [options] pod start foobar
         1c69bbfba8a4ad47516cdad9162751c3f5b57672be2a835821c0a7892315ef97
         Running: podman [options] container exists 21d775a67a44bb9deee0d5895f7bcfaa8bfd553847d68f7c87895c9bea2861b6
         Running: podman [options] pod stop foobar
         1c69bbfba8a4ad47516cdad9162751c3f5b57672be2a835821c0a7892315ef97
         Running: podman [options] pod start foobar
         1c69bbfba8a4ad47516cdad9162751c3f5b57672be2a835821c0a7892315ef97
         Running: podman [options] exec -it c0b94e4017e4766be71b2f22ee9a11ab2d8e7a82503c6d8d4f43b39ce1430386 cat /dev/shm/stbkBXTERreu
         RvmaTMZpEbGBRJfg      <------- expected: ENOENT, also expected exit status 1 (actual is 0)

This init functionality is new to me, and I haven't poked deeply enough to grok the test, but from my limited understanding this failure mode just shouldn't be possible. Filing as a placeholder.

Podman init containers [It] podman make sure once container is removed

Only fedora 33, and only since September. But just in case it's related, Ubuntu also had a failure, albeit a different error message:

Running: podman [options] exec -it b474b315832e6bf6cfdd1d5110b710302ef380ac97035a0fa9ca3034f88ab110 cat /dev/shm/sKRCHOZzSNUg
Error: container create failed (no logs from conmon): EOF    <--- yielding exit status 255, instead of the expected 1
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Sep 21, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2021

@baude PTAL

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

edsantiago commented Dec 13, 2021

Last 30 days:

Podman init containers [It] podman make sure once container is removed

@vrothberg
Copy link
Member

[...] exec -it 10742392702cc3a10235c7165007d81f6761502374d4fc7646bd2a896770c5f6 cat /dev/shm/MWQLTJoqqNsU
[...] Error: container create failed (no logs from conmon): EOF

@edsantiago is this the same as #10927?

@edsantiago
Copy link
Member Author

Oops. Yes, sorry. My script just reports the failing test, and I blindly copied. Sorry about that. I've edited my comment, and confirmed that the other failures (in 12520) are the once flake.

@vrothberg vrothberg self-assigned this Dec 14, 2021
@vrothberg
Copy link
Member

OK, I think I found something.

@vrothberg
Copy link
Member

I see two (separate) issues in the linked failures:

  1. podman [options] exec -it c733c9d4b1c641454b402d3fd54630656e45e725f8f34df66765c1075457f866 cat /dev/shm/ajFADnTdMnDi should exit 1 but sometimes exits 0. I see this only on F33 container! Since we don't exercise that anymore, I consider it "fixed". The file shouldn't be in /dev/shm anymore once the Pod got restarted and it exceeds my knowledge what may would go wrong there.

  2. The error below which I have a fix for:

         Running: podman [options] pod start foobar
         time="2021-10-23T01:13:43Z" level=error msg="Starting some container dependencies"
         time="2021-10-23T01:13:43Z" level=error msg="\"error creating systemd unit `libpod-c4240de22f92a54349e709c9131c9f7c7044936e1d6b5d0989736cbae3121d7e.scope`: got `failed`: OCI runtime error\""
         Error: error starting some containers: internal libpod error

@vrothberg
Copy link
Member

#12593 for 2)

@vrothberg
Copy link
Member

@edsantiago can you confirm my theory on 1)?

@edsantiago
Copy link
Member Author

I can't confirm it, but since you have a possible fix, and since f33 is gone, it's perfectly fine with me if we sweep (1) under the rug.

@vrothberg
Copy link
Member

Thanks!

@vrothberg
Copy link
Member

With #12593 merged, I am closing this issue.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

3 participants