Remove references to kube being development #11662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point and even though we are always improving the play and generate kube functions, I would say it no longers needs to be denoted as under development. [NO TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
Do we still generate that comment in new YAML? |
| header := `# Generation of Kubernetes YAML is still under development! | ||
| # | ||
| # Save the output of this file and use kubectl create -f to import | ||
| header := `# Save the output of this file and use kubectl create -f to import | ||
| # it into Kubernetes. |
There was a problem hiding this comment.
Suggested change
| # it into Kubernetes. |
| header := `# Generation of Kubernetes YAML is still under development! | ||
| # | ||
| # Save the output of this file and use kubectl create -f to import | ||
| header := `# Save the output of this file and use kubectl create -f to import |
There was a problem hiding this comment.
Suggested change
| header := `# Save the output of this file and use kubectl create -f to import | |
| header := `# Save the output of this file and use kubectl create -f to import into Kubernetes |
There was a problem hiding this comment.
i was trying to keep this at 80 characters before wrapping ... do you still want this done @TomSweeneyRedHat
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point and even though we are always improving the play and
generate kube functions, I would say it no longers needs to be denoted
as under development.
[NO TESTS NEEDED]
Signed-off-by: Brent Baude [email protected]