Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aardvark Test 5: Two containers on their own subnets, one container on both #14171

Closed
edsantiago opened this issue May 9, 2022 · 3 comments · Fixed by #14822
Closed

Aardvark Test 5: Two containers on their own subnets, one container on both #14171

edsantiago opened this issue May 9, 2022 · 3 comments · Fixed by #14822
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member 

  Aardvark Test 5: Two containers on their own subnets, one container on both
...
? Failure [9.418 seconds]
         Podman run networking
         /var/tmp/go/src/github.com[/containers/podman/test/e2e/run_aardvark_test.go:14](https://github.com/containers/podman/blob/8ecd0b5bc8b230dd9d213fb252178d1344744511/test/e2e/run_aardvark_test.go#L14)
           Aardvark Test 5: Two containers on their own subnets, one container on both [It]
           /var/tmp/go/src/github.com[/containers/podman/test/e2e/run_aardvark_test.go:204](https://github.com/containers/podman/blob/8ecd0b5bc8b230dd9d213fb252178d1344744511/test/e2e/run_aardvark_test.go#L204)
         
           Expected
               <string>: 
           to match regular expression
               <string>: (25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}
         
           /var/tmp/go/src/github.com[/containers/podman/test/e2e/common_test.go:1057](https://github.com/containers/podman/blob/8ecd0b5bc8b230dd9d213fb252178d1344744511/test/e2e/common_test.go#L1057)

Podman run networking [It] Aardvark Test 5: Two containers on their own subnets, one container on both
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label May 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

Podman run networking [It] Aardvark Test 5: Two containers on their own subnets, one container on both

flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 14, 2022
@flouthoc
main: run aardvark as a daemon via double-forking
780f281 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that double-forking will happen at aardvark-end instead of
netavark.

Redesign proposal

* Aardvark will invoke server on the child process by double-forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc mentioned this issue Jun 14, 2022
Merged
@flouthoc
Copy link
Collaborator

There is a bigger design change under discussion which should help in this as well as some other issue, please track it here. However it will take some time to get merged: containers/aardvark-dns#148

flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 14, 2022
@flouthoc
main: run aardvark as a daemon via double-forking
29eac3c 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that double-forking will happen at aardvark-end instead of
netavark.

Redesign proposal

* Aardvark will invoke server on the child process by double-forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
aa61a9c 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc mentioned this issue Jun 15, 2022
Merged
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
f3d9392 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
b08879c 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
7b8dd89 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
0441806 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 15, 2022
@flouthoc
main: run aardvark as a daemon via forking
60e8883 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 16, 2022
@flouthoc
main: run aardvark as a daemon via forking
4107b83 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jun 16, 2022
@flouthoc
main: run aardvark as a daemon via forking
383e425 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
Luap99 added a commit to Luap99/libpod that referenced this issue Jul 4, 2022
@Luap99
fix flake in aardvark tests
4c5b058 
The retry logic in digshort() did not work because dig always exits with
0 even when the domain name is not found. To make it work we have to
check the standard output.

We work on fixing the underlying issue in aardvark/netavark but
this will take more time.

Fixes containers#14173
Fixes containers#14171

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Jul 4, 2022
Merged
flouthoc added a commit to flouthoc/aardvark-dns that referenced this issue Jul 13, 2022
@flouthoc
main: run aardvark as a daemon via forking
631a2b6 
This is one the redesign PR for aardvark-dns and netavark. Design
proposes that  forking will happen at aardvark-end instead of
netavark and aardvark will verify if servers are up before parent goes
away.

Redesign proposal

* Aardvark will invoke server on the child process by  forking.
* Parent waits for child to show up  and verify against a dummy DNS
  query to check if server is running.
* Exit parent on success and deatch child.

* Calling process will wait for aardvark's parent process to return.
* On successful return from parent it will be assumed that aardvark is
  running properly

One new design is implemented and merged and netavark starts using this
it should close

* containers/podman#14173
* containers/podman#14171

Signed-off-by: Aditya R <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix flake in aardvark tests Luap99/libpod
3 participants
@edsantiago @rhatdan @flouthoc