k8systemd: run k8s workloads in systemd

[vrothberg]

Support running podman play kube in systemd by exploiting the
previously added "service containers". During play kube, a service
container is started before all the pods and containers, and is stopped
last. The service container communicates its conmon PID via sdnotify.

Add a new systemd template to dispatch such k8s workloads. The argument
of the template is the path to the k8s file. Note that the path must be
escaped for systemd not to bark:

Let's assume we have a top.yaml file in the home directory:

$ escaped=$(systemd-escape ~/top.yaml)
$ systemctl --user start podman-play-kube@$escaped.service

Closes: https://issues.redhat.com/browse/RUN-1287
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

Add new `[email protected]` systemd template to dispatch K8s YAML files in systemd.
The path to the YAML file must be escaped: `systemctl --user start podman-play-kube@$(systemd-escape $YAML).service`

@mheon @baude @rhatdan PTAL

[vrothberg]

@edsantiago, I would love your eyes to have a look at the tests.

[vrothberg]

Fixed the is-failed check in the tests

[edsantiago]

Tests fail; I'll review again once tests pass

[vrothberg]

Integration networking tests are very flaky atm.

[edsantiago]

Please use this: 250-systemd.bats.txt

(too big a diff, easier to just post new file).

I can't actually get it to pass, the podman rm -a fails with:

  $ .../bin/podman rm -a                                                                                                
   4a2a246fd96275bd339ac756be888de9d280e43b7403da261c631f4fc76e75fe                                                                                             
   6978083adf9c0787462493ab0ae1f4c2a9053ab8c532e6db2014dfde29d035c9                                                                                             
   Error: container 05952888d26655a6c6bae3f8429f1dd9b8fbb899739210ccebe758bd60268d29 does not exist in database: no such container                              
   [ rc=1 (** EXPECTED 0 **) ]             

...but I'll leave that for you to look into

[vrothberg]

Please use this: 250-systemd.bats.txt

(too big a diff, easier to just post new file).

Absolute great work, @edsantiago. Thank you!

[vrothberg]

@mheon @edsantiago PTanotherL. Thanks for the reviews!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Tests LGTM. Thanks for solving the "does not exist" issue and for finding/fixing the other instances of hardcoded hash.

[mheon]

LGTM

[edsantiago]

System test failing and looks real:

         # $ podman pod inspect test_pod --format {{.State}}
         # Exited
         # $ podman container inspect b9180307e1fd-service --format {{.State.Running}}
         # true
         # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
         # #|     FAIL: podman container inspect b9180307e1fd-service --format {{.State.Running}}
         # #| expected: 'false'
         # #|   actual: 'true'
         # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[vrothberg]

System test failing and looks real:

Looks like a race in the tests I didn't anticipate before. Glad it flaked in this PR and not after.

[vrothberg]

System test failing and looks real:

Looks like a race in the tests I didn't anticipate before. Glad it flaked in this PR and not after.

Fixed now o/

[vrothberg]

Ready.

@edsantiago @rhatdan @mheon

[edsantiago]

The best part of functions is that you can simply return. Then the fallthrough can simply be die "Timed out waiting for .State.Running on $1 to be $2.

But it's not worth a repush, this is just something for next time. LGTM.

[vrothberg]

Thanks for explaining! Looks like I need to ramp up my bash skills a bit further.

[edsantiago]

Tests LGTM; the rest is more than I can approve

[rhatdan]

/lgtm