Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play kube default log driver #14060

Merged
merged 1 commit into from
May 4, 2022
Merged

play kube default log driver #14060

merged 1 commit into from
May 4, 2022

Conversation

nicrowe00
Copy link
Collaborator

The default log driver is not used when using play kube
without --log-driver. The LogDriver function needs to
be called in order to use the default log driver.

fixes #13781
Signed-off-by: Niall Crowe [email protected]

@nicrowe00
Copy link
Collaborator Author

@vrothberg PTAL

vrothberg
vrothberg reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

giuseppe
giuseppe approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, nicrowe00

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
Luap99
Luap99 reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how the test actually makes sure the correct default is chosen. It should not rely on the default value. Instead use a custom containers.conf and test with both journald and k8s-file as default.

The current patch will also not work via remote. The defaults must be set on server side.

test/system/700-play.bats Outdated Show resolved Hide resolved
@rhatdan rhatdan removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@vrothberg
Copy link
Member

I am not sure how the test actually makes sure the correct default is chosen. It should not rely on the default value. Instead use a custom containers.conf and test with both journald and k8s-file as default.

The entire point is to use the default value. podman info returns the one from the server, so I don't think we need a custom containers.conf.

The current patch will also not work via remote. The defaults must be set on server side.

Good point. I didn't test it with remote yet. We'll probably need some further tweaks for the remote code.

Luap99
Luap99 reviewed Apr 29, 2022
View reviewed changes
test/system/700-play.bats Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

All kinds of tests unhappiness.
Code LGTM, I'll let you all thumb wrestle over the test completeness.

vrothberg
vrothberg reviewed May 4, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remote int flakes are unrelated.

pkg/api/handlers/libpod/play.go Show resolved Hide resolved
pkg/api/handlers/libpod/play.go Outdated Show resolved Hide resolved
test/system/700-play.bats Outdated Show resolved Hide resolved
@nicrowe00
play kube default log driver
ccd5765 
The default log driver is not used when using play kube
without --log-driver. The LogDriver function needs to
be called in order to use the default log driver.

fixes #13781
Signed-off-by: Niall Crowe <[email protected]>
@vrothberg
Copy link
Member

@containers/podman-maintainers PTAL

I restarted the flaked job.

@mheon
Copy link
Member

mheon commented May 4, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented May 4, 2022

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit b1e9ea3 into containers:main May 4, 2022
@edsantiago edsantiago mentioned this pull request May 9, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg left review comments

@edsantiago edsantiago edsantiago left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

play kube does not use default log driver
9 participants
@nicrowe00 @vrothberg @TomSweeneyRedHat @mheon @rhatdan @giuseppe @edsantiago @Luap99 @openshift-merge-robot