Fix ptsname() for big-endian architectures

[pmorjan]

On big-endian architectures unix.IoctlGetInt() leads to a wrong result
because a 32 bit value is stored into a 64 bit buffer. When dereferencing
the result is left shifted by 32. Without this patch ptsname() returns
a wrong path from the second pty onwards.
To protect syscalls against re-arranging by the GC the conversion from
unsafe.Pointer to uintptr must occur in the Syscall expression itself.
See the documentation of the unsafe package for details.

Signed-off-by: Peter Morjan [email protected]

[estesp]

The Solaris build break with Go 1.9.4 is a known issue** (fixed in 1.10 which is why travis "tip" succeeds).

Should we: a) fix Golang 1.9.x to 1.9.3 in travis, b) move travis to 1.10, or c) remove Solaris from travis unless we have known use?

** hashicorp/consul#3879

[crosbymichael]

Maybe pin to 1.9.3 so we don't lose solaris builds. I know we have some solaris users of this package so it would be nice to keep the build.

[crosbymichael]

By pin, i mean 1.9.3 and 1.10/tip

[pmorjan]

You can allow Travis to fail for a particular Go version:
https://travis-ci.org/pmorjan/console
https://github.com/pmorjan/console/blob/travis/.travis.yml

language: go
go:
  - 1.9.3
  - 1.9.x
  - tip

go_import_path: github.com/containerd/console

install:
  - go get -d
  - GOOS=windows go get -d
  - GOOS=solaris go get -d

script:
  - go test -race
  - GOOS=windows go test
  - GOOS=solaris go build
  - GOOS=solaris go test -c

matrix:
  allow_failures:
    - go: 1.9.x

[crosbymichael]

Works for me. Maybe allow failures only for 1.9.4?

[pmorjan]

but then you can't use the 1.9.x glob any more

this works:
========
go:
  - 1.9.3
  - 1.9.4
  - tip
matrix:
  allow_failures:
    - go: 1.9.4

this doesn't work
==========
go:
  - 1.9.x
  - 1.9.4
  - tip
matrix:
  allow_failures:
    - go: 1.9.4

[crosbymichael]

Ok, that works for me. Thanks for debugging

[crosbymichael]

LGTM

[estesp]

LGTM