Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal is broken on s390 (regression in rc93) #2896

Closed
kolyshkin opened this issue Apr 6, 2021 · 1 comment · Fixed by #2898
Closed

terminal is broken on s390 (regression in rc93) #2896

kolyshkin opened this issue Apr 6, 2021 · 1 comment · Fixed by #2898
Labels
impact/changelog
Milestone
1.0.0-rc94

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Apr 6, 2021 •
edited
Loading

Initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=1941815. On s390, runc run/exec can't open a terminal:

ERRO[0000] exec failed: container_linux.go:367: starting container process caused: open /dev/pts/4294967296: no such file or directory

This is a regression which has previously reported (moby/moby#36467) and fixed (containerd/console#20, #1727).

Unfortunately, it has resurfaced. I think containerd/console#42 and #2616 are the ones to blame, so this is a regression in rc93.

Fix for containerd/console is here: containerd/console#51. Once in, we need to revendor it.
@kolyshkin kolyshkin added this to the 1.0.0-rc94 milestone Apr 6, 2021
@kolyshkin kolyshkin changed the title terminal is broken on s390 terminal is broken on s390 (regression in rc93) Apr 6, 2021
@cyphar cyphar mentioned this issue Apr 7, 2021
Closed
@Prashanth684
Copy link

with containerd/console#51 being fixed, i guess we can revendor now?

kolyshkin added a commit to kolyshkin/runc that referenced this issue Apr 8, 2021
@kolyshkin
vendor: bump containerd/console to 1.0.2-pre
6981db7 
This is to include containerd/console#51

Fixes: opencontainers#2896

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin mentioned this issue Apr 8, 2021
Merged
kolyshkin added a commit to kolyshkin/runc that referenced this issue Apr 8, 2021
@kolyshkin
vendor: bump containerd/console to 1.0.2-pre
d9ea176 
This is to include containerd/console#51

Fixes: opencontainers#2896

Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin added a commit to kolyshkin/runc that referenced this issue Apr 12, 2021
@kolyshkin
vendor: bump containerd/console to 1.0.2
b7c315a 
This is to include containerd/console#51.

Fixes: opencontainers#2896

Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin added a commit to kolyshkin/runc-1 that referenced this issue Apr 15, 2021
@kolyshkin
vendor: bump containerd/console to 1.0.2
c7dc0cb 
This is to include containerd/console#51.

Fixes: opencontainers/runc#2896

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/changelog
Projects
None yet
Milestone
1.0.0-rc94
Development

Successfully merging a pull request may close this issue.

vendor: bump containerd/console to 1.0.2 kolyshkin/runc
2 participants
@Prashanth684 @kolyshkin