Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Update github.com/containerd/console in vendor #410

Closed
alicefr opened this issue Nov 14, 2018 · 4 comments
Closed

Update github.com/containerd/console in vendor #410

alicefr opened this issue Nov 14, 2018 · 4 comments

Comments

@alicefr
Copy link

alicefr commented Nov 14, 2018

Description of problem

I'm working on IBM Z support for kata. IBM Z is a big endian architecture and the old version of the github.com/containerd/console has a bug. The issue has already been solved for runc see issue with this fix in the console package. The github.com/containerd/console needs to be updated to include the fix. The bug shows up with exec command

$ bundle="/tmp/bundle"
$ rootfs="$bundle/rootfs"
$ mkdir -p "$rootfs" && (cd "$bundle" && kata-runtime spec)
$ sudo docker export $(sudo docker create busybox) | tar -C "$rootfs" -xvf -
$ kata-runtime --log=/dev/stdout run --bundle "$bundle" foo
# In another terminal
$ kata-runtime exec -t foo
rpc error: code = Internal desc = Could not run process: container_linux.go:348: starting container process caused "open /dev/pts/4294967296: no such file or directory"
@alicefr
Copy link
Author

alicefr commented Nov 14, 2018

Could you please help me how can I properly update the github.com/containerd/console. The runc commit in Gopkg.toml seems already to include the fix, but the containerd/console doesn't.

$ cd $GOPATH/src/github.com/opencontainers/runc
$ COMMIT_FIX=59e5b61c5c57a6e8f9ad54860a02cde75a6024db
$ KATA_RUNC=cc4307ab6643668ce5abc6b524e1764a54c32550
$ git merge-base --is-ancestor $KATA_RUNC $COMMIT_FIX; echo $?
1

@caoruidong
Copy link
Member

caoruidong commented Nov 14, 2018

Unfortunately, the version of containerd/console is an older one.

agent/Gopkg.lock

Lines 4 to 10 in 3bef612

[[projects]]
branch = "master"
digest = "1:86feeb6c372fd7984322882737b00f32d7e75c6b437f93d75f43db3195574dab"
name = "github.com/containerd/console"
packages = ["."]
pruneopts = "NUT"
revision = "84eeaae905fa414d03e07bcd6c8d3f19e7cf180e"
I think maybe kata code dosen't call into this package. You can add a constrain explicitly in Gopkg.toml.

@alicefr
Copy link
Author

alicefr commented Nov 14, 2018

Do you mean to add the console package in Gopkg.toml as dependency?

@caoruidong
Copy link
Member

Yes. I don't know why it happens. cc @jodh-intel

alicefr pushed a commit to alicefr/agent that referenced this issue Nov 14, 2018
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 14, 2018
This PR fixes the issue kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166.

The console package has been add in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 14, 2018
This PR fixes the issue kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166.

The console package has been add in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 14, 2018
This PR fixes the issue kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166 (commit that fixed the big-endian issue)

The console package has been added in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 15, 2018
The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166 (commit that fixed the big-endian issue)

The console package has been added in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 15, 2018
Fixes: kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166 (commit that fixed the big-endian issue)

The console package has been added in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/agent that referenced this issue Nov 15, 2018
Fixes: kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166 (commit that fixed the big-endian issue)

The console package has been added in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
@sboeuf sboeuf closed this as completed in 7b4c337 Nov 15, 2018
jshachm pushed a commit to jshachm/agent that referenced this issue Nov 22, 2018
Fixes: kata-containers#410

The console package in vendor contains a big endian bug. The issue has
already been solved in runc. See PRs:
 - opencontainers/runc#1727
 - containerd/console#20

The console version has been updated from commit 84eeaae905 to commit
2748ece166 (commit that fixed the big-endian issue)

The console package has been added in the Gopkg.toml because the console
package is not directly used in the code and the dep command doesn't
automatically update the console package.

Signed-off-by: Alice Frosi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants