-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sys.exit
with CondaBuildUserError
exceptions
#5255
Draft
kenodegard
wants to merge
33
commits into
conda:main
Choose a base branch
from
kenodegard:remove-sys.exit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Mar 25, 2024
CodSpeed Performance ReportMerging #5255 will not alter performanceComparing Summary
|
dholth
reviewed
Mar 25, 2024
dholth
reviewed
Mar 25, 2024
This was referenced Mar 27, 2024
Merged
beeankha
force-pushed
the
remove-sys.exit
branch
from
April 3, 2024 20:55
89eae7d
to
f9c4ea7
Compare
3 tasks
kenodegard
force-pushed
the
remove-sys.exit
branch
2 times, most recently
from
May 20, 2024 21:00
697a07b
to
1943a58
Compare
This was referenced May 23, 2024
This was referenced Jun 11, 2024
beeankha
added a commit
to beeankha/conda-build
that referenced
this pull request
Jun 25, 2024
3 tasks
beeankha
added a commit
that referenced
this pull request
Jul 8, 2024
* Update exceptions imports/usage in metadata.py * Replace sys.exit call with CondaBuildUserError for select_lines() function * Add unit test for CondaBuildUserError exception in select_lines test * Replace sys.exit call in _git_clean() and add unit test * Replace sys.exit call in check_bad_chrs() and add unit test * Update import statements and remove sys.exit call from yamlize() * Mark _get_env_path() for deprecation * Remove sys.exit call from parse_until_resolved() and add unit test * Remove sys.exit call from _get_contents() * Ignore deprecation warnings in metadata.py tests, point to correct exception in test_jinja_typo in test_api_build.py * Relax match string in error assertion for Windows * Revert 'cleanup' code changes from #5255
3 tasks
kenodegard
force-pushed
the
remove-sys.exit
branch
from
July 23, 2024 01:45
7c50dd6
to
28df04b
Compare
3 tasks
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4209
Resolves #5242Checklist - did you ...
news
directory (using the template) for the next release's release notes?