Remove sys.exit from develop.py
#5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5453 will not alter performanceComparing Summary
|
kenodegard
reviewed
Aug 9, 2024
kenodegard
reviewed
Aug 9, 2024
tests/test_develop.py
Outdated
| @@ -99,3 +102,22 @@ def test_uninstall(site_packages: Path, conda_pth: Path): | |||
| _uninstall(site_packages, path) | |||
|
|
|||
| assert list(filter(None, conda_pth.read_text().split("\n"))) == develop_paths | |||
|
|
|||
|
|
|||
| def test_get_setup_py(conda_pth: Path): | |||
There was a problem hiding this comment.
The conda_pth fixture you use here does not appear to be used since it's overwritten on line 109?
kenodegard
reviewed
Aug 9, 2024
Co-authored-by: Ken Odegard <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
kenodegard
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing
sys.exitcalls inconda_build/develop.pywith the newCondaBuildUserErrorexception for better error handling + unit tests.The changes in this PR are separated out from work previously done by @kenodegard in #5255
Xref #4209
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?