Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_guess_interpreter #5265

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Conversation

kenodegard
Copy link
Contributor

Description

While working on #5255 found that conda_build.build.guess_interpreter actually guesses incorrectly for certain extensions (e.g., .sh_what, .bat_what, .ps1_what, .py_what).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 28, 2024
@kenodegard kenodegard force-pushed the test_guess_interpreter branch from 7a75640 to b95083a Compare March 28, 2024 19:18
Copy link

codspeed-hq bot commented Mar 28, 2024

CodSpeed Performance Report

Merging #5265 will not alter performance

Comparing kenodegard:test_guess_interpreter (9664414) with main (9267dae)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard force-pushed the test_guess_interpreter branch from 57a82b2 to 75abc16 Compare March 29, 2024 14:53
@kenodegard kenodegard marked this pull request as ready for review March 29, 2024 19:32
@kenodegard kenodegard requested a review from a team as a code owner March 29, 2024 19:32
@jezdez jezdez merged commit 19997b9 into conda:main Apr 3, 2024
28 checks passed
@kenodegard kenodegard deleted the test_guess_interpreter branch April 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants