Error messages on api requests printed to users #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #260 We are now dependant on the rest api
pierrotsmnrd
pushed a commit
that referenced
this pull request
May 10, 2022
Closes #260 We are now dependant on the rest api
costrouc
added a commit
that referenced
this pull request
Dec 12, 2022
* .gitignore DS_Store * First step : rework schema+ORM & builds working * Post /api/v1/specification should return build id on success (#244) Closes #243 * Keep similar return values to other endpoints * Bump version to v0.3.10 * CI: Add Docker layer caching for conda store and server (#234) * CI: Add Docker layer caching for conda store and server * CHORE: Add Hadolint for Dockerfile linting * CI: Add Docker Build Push action and caching * CI: Add setup Buildx action * CI: Add Docker Build Push action and caching for release workflow * Adding ability for conda-store server to use proxy X-Forward- headers (#249) * Adding ability for conda-store server to use proxy X-Forward- headers * Fixing github-actions specification * Black formatting * Spelling * Limits to the concurrency of celery/conda-store-worker (#250) Closes #247 This is a shorter term fix but does seem to effectively limit the number of connections. * Inconsistancy buildId vs build_id. Chose build_id to prefer the python approach (#251) Closes #245 * Adding ability to modify and validate specification (#252) * Adding ability to modify and validate specification Closes #117 * Adding stricter validation of schemas * Flake8 error * Adding documentation * Documentation linting errors * Add concurrency setting to example Docker Conda Store config file (#254) * Specification custom validation and modifications (#256) * Adding sane defaults to conda-store for environments channels/packages Closes #253 * Black formatting * Adding documentation * Making schema more robust * Black formatting * Docker compose add gator (#255) * For local dev, allow access to all endpoints * Install dev branch of Gator * Adding filesystem to default environment * Setup condarc properly * Making ipykernel always be added to environment Co-authored-by: Chris Ostrouchov <[email protected]> * Bump version v0.3.11 * Fixing vale documentation errors * Making conda package population independent from package builds (#258) * Making conda package population independent from package builds Closes #257 * Adding conda to the dependencies * Error messages on api requests printed to users (#261) Closes #260 We are now dependant on the rest api * Fix #263 : exact search (#264) * gitignore .DS_Store * fix #263 : adding `exact` param to use w `search` * update in documentation for `exact` with `search` * black formatting * flake8 * Adding lockfile implementation to conda-store builds (#268) * Adding lockfile implementation to conda-store builds Closes #267 * Changing default behavior to build conda environments serialy Closes #267 * Black formatting * Adding documentation * Vale spelling * Bump version 0.3.12 * Adding permissions view to user ui endpoint along with api endpoint (#271) * Adding permissions view to user ui endpoint along with api endpoint * Adding documentation on the new permissions * Black formatting * Split namespace and name in UI for user * Bump version 0.3.13 * typo: user.html Bellow -> Below * Bump minimist from 1.2.5 to 1.2.6 in /tests/e2e (#272) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Account for None, "" values for namespace (#274) Closes #273 * Bump version to 0.3.14 * Fixing kubernetes example * Sort namespaces in create environment, correct default namespace, allow cookies cross domain * Make concurrency setting optional * Debug mode now controlled by log_level This weirdly caused the kubernetes example to reload. Fixed. * Bump version to 0.3.15 * Kuberntes example now uses v0.3.15 * Transition to FastAPI for web server (#277) * Initial work to integrate fastapi * Further work on fastapi integration * Further work with fastapi in ui routes * About 50% of the routes working properly * Adding post specification route * All routes appear to be working * Black and Flake8 formatting * Enable docker registry * Restore behind proxy * Adding redirect when using prefix for convenience * Adding version and cleaning up docker-compose file * Black and Flake8 formatting * Bump black version * Fixing login method to be api driven * Remove mysql from standard test * Update tests to do username/password login * Remove double pass for auth * Wait for build to complete * Checking for build status * Adding tests to run after api is running * Adding initial integration tests * Tests for all get api routes * Black and Flake8 formatting * Running integration tests in PR * Move conda import into inside of function * Move conda imports behind functions * Black formatting * Use root pytest directory * Black and Flake8 formatting * Adding test for namespace not specified * Further testing on api * Fixing delete endpoint * Black formatting * Fix docker examples * Black and flake8 formatting * Fixing the traitlet that allows for the callback url customization * Fully tested api for /api/v1/... endpoints * Bump moment from 2.29.1 to 2.29.2 in /tests/e2e (#281) Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Creating a conda solve api endpoint (#279) * Minimal work to get a cachable solve api * Adding api endpoint for solve * Working celery task queue based solver * Black and Flake8 formatting * Fixing docker example to have working conda-store extension * Fix bug in link checker (hopefully pin to something other than master) * Bump async from 3.2.0 to 3.2.3 in /tests/e2e (#282) Bumps [async](https://github.com/caolan/async) from 3.2.0 to 3.2.3. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md) - [Commits](caolan/async@v3.2.0...v3.2.3) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Extract package name from included and required packages (#283) * Extract package name from matchspec for conda packages * Black formatting * Adding yarn to dependencies * Adding pypi package validation for required, included, and default (#292) * Adding pypi included, required, and default packages Closes #291 * Black and flake8 formatting * Update tests to 3.7+ * Fix #294 : yaml spec file uses pip options (#295) * Fix #294 : yaml spec file uses pip options * black formatting * fix pip params * Adding edge case checks for if option is invalid * Black formatting * Making the match non greedy for command Co-authored-by: Chris Ostrouchov <[email protected]> * Bump version to 0.4.0 * Fixes for pip support (#298) .extend not available on Python dict options (e.g. --index-url) were getting swallowed and not added to final spec * First step : rework schema+ORM & builds working * Impacts after split conda package ➞ package/builds * black * flake8 * update_conda_packages massive improvement * Improve redis config * solve_conda_package ➞ solve_conda_package_build * merge main into fix167_api_perf (squashed commit) commit 1a326a5 Author: eskild <[email protected]> Date: Mon Aug 22 22:42:54 2022 -0700 add note for macOS development (#384) * Add note for MacOS dev * Restore: USER root commit 5a7c19d Author: Pierre-Olivier Simonard <[email protected]> Date: Fri Aug 19 18:55:27 2022 +0200 return description in get api/v1/environment/ (#383) commit 61168ea Author: Harsh Mishra <[email protected]> Date: Thu Aug 18 23:19:35 2022 +0530 feat: visually split Namespace and Name in UI (#374) * feat: visually split Namespace and Name in UI * fix cypress commit 673bef1 Author: Christopher Ostrouchov <[email protected]> Date: Wed Aug 17 14:26:40 2022 -0400 Make image name and tag configurable for uploads to registries (#380) * Make image name and tag configurable for uploads to registries * Adding documentation commit 1d1bac6 Author: Chris Ostrouchov <[email protected]> Date: Wed Aug 17 13:40:09 2022 -0400 Traitlets unions of callables or values commit 6482fc4 Author: Chris Ostrouchov <[email protected]> Date: Wed Aug 17 11:47:57 2022 -0400 Adding installation instructions commit 5a2bebf Author: Chris Ostrouchov <[email protected]> Date: Wed Aug 17 10:23:52 2022 -0400 Bump version 0.4.11 commit 0531782 Author: Christopher Ostrouchov <[email protected]> Date: Wed Aug 17 10:22:26 2022 -0400 Fixing data being packaged into conda_store_server (#379) commit 5a7527e Author: Chris Ostrouchov <[email protected]> Date: Tue Aug 16 22:32:23 2022 -0400 Bump version 0.4.10 commit 211c8be Author: Christopher Ostrouchov <[email protected]> Date: Tue Aug 16 22:27:01 2022 -0400 Remove the need for configuration for conda-store-server (#378) Motivation is to ensure that there is always a simple way to run conda-store. Standalone mode will provide the option. commit 8372a58 Author: Christopher Ostrouchov <[email protected]> Date: Tue Aug 16 17:13:02 2022 -0400 Fix storage.LocalStorage option adding standalone running option for conda-store (#376) * Fixing local storage option to ensure working * Black formatting * Alembic use bulk alter statements * Black and Flake8 formatting * Removing commented out code * Adding documentation commit 5ee8519 Merge: a13571c c10f127 Author: Vinicius D. Cerutti <[email protected]> Date: Tue Aug 16 13:06:02 2022 -0300 Merge pull request #365 from Quansight/helm-chart Setup conda-store helm charts for automated build and publish commit a13571c Author: Chris Ostrouchov <[email protected]> Date: Tue Aug 16 12:02:50 2022 -0400 Black formatting commit d9c971d Author: jonzeper <[email protected]> Date: Tue Aug 16 09:02:12 2022 -0700 Fix 'should store docker manifest?' check (#377) commit c10f127 Author: HarshCasper <[email protected]> Date: Tue Aug 16 20:53:41 2022 +0530 add comments commit d5433ce Author: HarshCasper <[email protected]> Date: Tue Aug 16 20:19:40 2022 +0530 ci: remove shell script and run commands on gha commit 9d353bf Author: Pierre-Olivier Simonard <[email protected]> Date: Wed Aug 10 14:45:58 2022 +0200 Fix CORS on login endpoint (#375) * Fix CORS on login endpoint * black commit 774af33 Author: Chris Ostrouchov <[email protected]> Date: Tue Aug 9 22:36:26 2022 -0400 Bump version 0.4.9 commit 2e51f69 Author: Christopher Ostrouchov <[email protected]> Date: Tue Aug 9 12:50:45 2022 -0400 push/pull container images to/from additionall registries (#370) * Completed registry implementation * Lifecycle management of built container images push/pull/delete * Removing commited container registry example commit 1eb3e4e Author: Pierre-Olivier Simonard <[email protected]> Date: Tue Aug 9 15:45:35 2022 +0200 Fix when updating an env (#372) commit dfb4eda Author: Pierre-Olivier Simonard <[email protected]> Date: Thu Aug 4 17:06:28 2022 +0200 Fix 339 env description (#363) * adding field description on environment model * alembic migration for environment.description * API impact to update an env description * black * handle environment.description when add an env commit 2f8d979 Author: Chris Ostrouchov <[email protected]> Date: Thu Aug 4 00:58:02 2022 -0400 Bump version 0.4.8 commit cc46122 Author: Christopher Ostrouchov <[email protected]> Date: Thu Aug 4 00:46:17 2022 -0400 Adding authentication behind docker registry (#369) * Adding authentication behind registry * Black formatting * Adding documentation commit 09f2b7f Author: Christopher Ostrouchov <[email protected]> Date: Wed Aug 3 20:48:09 2022 -0400 Fixing docker registry implementation in conda-store (#368) commit f7607f4 Author: Chris Ostrouchov <[email protected]> Date: Wed Aug 3 12:01:40 2022 -0400 Fix examples demo commit 2fca851 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Aug 2 09:57:32 2022 -0400 Bump moment from 2.29.2 to 2.29.4 in /tests/e2e (#364) Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.2...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f02921f Author: Pierre-Olivier Simonard <[email protected]> Date: Tue Aug 2 15:57:15 2022 +0200 This is necessary for auth to work (really) (#366) commit 38aa171 Author: HarshCasper <[email protected]> Date: Mon Aug 1 13:18:10 2022 +0530 CI: Refactor helm chart publish action into release workflow commit f118ffc Author: HarshCasper <[email protected]> Date: Mon Aug 1 13:16:36 2022 +0530 Setup conda-store helm charts for automated build and publish commit 5d4c0ab Author: Christopher Ostrouchov <[email protected]> Date: Sat Jul 30 14:06:07 2022 -0400 Adding shebang support for conda-store (#362) * Adding shebang support for conda-store Feature motivated from https://gist.github.com/travisbhartwell/f972aab227306edfcfea * Adding documentation on shebang feature commit 92e5646 Author: Chris Ostrouchov <[email protected]> Date: Thu Jul 28 22:11:39 2022 -0400 Bump version to 0.4.7 commit 03b5ddd Author: Chris Ostrouchov <[email protected]> Date: Thu Jul 28 21:45:45 2022 -0400 Updating CHANGELOG to reflect changes since last release commit 949daed Author: Christopher Ostrouchov <[email protected]> Date: Thu Jul 28 00:18:24 2022 -0400 Add option to allow all channels is empty (#358) commit 36976b1 Author: Chris Ostrouchov <[email protected]> Date: Fri Jul 22 13:16:48 2022 -0400 Changing the default build gid commit 04d9611 Author: Alan Braz <[email protected]> Date: Fri Jul 22 14:15:35 2022 -0300 enforce user 1000 group 1000 #305 (#355) * enforce user 1000 group 1000 #305 * files permission commit 818d326 Author: Chris Ostrouchov <[email protected]> Date: Wed Jul 20 10:12:48 2022 -0400 Update test to reflect changed defaults commit 06faf03 Author: Jun Aishima <[email protected]> Date: Wed Jul 20 10:04:16 2022 -0400 add repo.anaconda.com to default (#354) * as noted by @costrouc after an environment build failure, add a new channel URL that is used by some conda-forge packages to conda_allowed_channels commit 3c1830b Author: Pierre-Olivier Simonard <[email protected]> Date: Sat Jul 16 15:05:38 2022 +0200 fix 351 : sort builds by start/scheduled/end dt (#352) * fix 351 : sort builds by start/scheduled/end dt * linting commit 0dc3768 Author: Christopher Ostrouchov <[email protected]> Date: Thu Jul 14 14:33:12 2022 -0400 Adding additional query parameters for environment_id, namespace, name in list builds (#350) * Adding additional query parameters for environment_id, namespace, name in list builds Closes #349 * Black formatting commit 2c33bb0 Author: Chris Ostrouchov <[email protected]> Date: Fri Jul 8 17:24:20 2022 -0400 Bump version 0.4.6 commit 807e579 Author: Christopher Ostrouchov <[email protected]> Date: Fri Jul 8 17:22:18 2022 -0400 Copy token button (#348) commit 135b036 Author: Chris Ostrouchov <[email protected]> Date: Fri Jul 8 16:28:52 2022 -0400 Updating changelog commit 15d5393 Author: Christopher Ostrouchov <[email protected]> Date: Fri Jul 8 16:25:07 2022 -0400 Adding c.CondaStoreServer.template_vars and banner, logo (#347) * Adding template_vars to CondaStoreServer * Adding docs on how to use template commit fd5be25 Author: Christopher Ostrouchov <[email protected]> Date: Fri Jul 8 13:11:00 2022 -0400 FIX: Adding trait authenticated_role_bindings as config value (#346) commit 795c889 Author: Christopher Ostrouchov <[email protected]> Date: Fri Jul 8 10:14:37 2022 -0400 Chaning inconsistent usage Conda-Store, Conda Store -> conda-store (#345) * Chaning inconsistent usage Conda-Store, Conda Store -> conda-store Closes #340 * Adding details on proper naming commit 038165b Author: Christopher Ostrouchov <[email protected]> Date: Mon Jul 4 23:40:26 2022 -0400 Adding docker example without nfs (#337) commit 473f812 Author: Christopher Ostrouchov <[email protected]> Date: Mon Jul 4 13:49:44 2022 -0400 Remove gator from the docker image (#336) * Remove gator from the docker image * Fix demo login * No auth confirmation * Typo in cli command commit dd61bcd Author: Christopher Ostrouchov <[email protected]> Date: Sat Jul 2 15:58:11 2022 -0400 Adding token endpoint along with tests (#335) * Adding token endpoint along with tests * Black and Flake8 formatting * Adding tests for getting tokens * Adding tests and subset function for tokens * Working token creation commit 846c93a Author: Chris Ostrouchov <[email protected]> Date: Wed Jun 29 21:23:57 2022 -0400 Bump version 0.4.5 commit 87df1db Author: Christopher Ostrouchov <[email protected]> Date: Wed Jun 29 21:14:12 2022 -0400 Adding cli commands for new server filters along with updating docs (#330) * Adding cli commands for new filters * Adding more cli checks commit 774a194 Author: Christopher Ostrouchov <[email protected]> Date: Wed Jun 29 01:55:23 2022 -0400 API builds/environments filter on packages, status (#329) * API builds/environments filter on packages, status * Allow filtering over artifact type * Working queries for all conditions commit d605ab8 Author: Pierre-Olivier Simonard <[email protected]> Date: Mon Jun 27 13:45:46 2022 +0200 Adding alembic and first migration to build DB (#314) * Adding alembic and first migration to build DB - required adding use_alter on Environment.current_build_id to allow it to work. It basically says that the Foreign key must be added doing an ALTER TABLE instead of adding it during the CREATE TABLE. Without it, there's a conflict because Environment needs Build to exist to be created, and vice-versa. - we now need a way to run `alembic upgrade head` before conda-store-server starts, and disable the auto creation of the DB from the ORM that is done in `orm.new_session_factory` - We also need to add documentation on how to add a migration * migration on server init + handle first migration * black * Flake8 * black (version 22.3.0 ...) * Fix in revision stamping * Documentation on migrations * move `upgrade_db` to CondaStore with traitlets * black and cleanup commit b734278 Author: Chris Ostrouchov <[email protected]> Date: Sat Jun 25 21:31:50 2022 -0400 Bump version 0.4.4 commit a2a5548 Author: Christopher Ostrouchov <[email protected]> Date: Sat Jun 25 21:27:52 2022 -0400 Adding cli for waiting on builds along with better URI handling (#328) * Adding cli for waiting * Black and Flake8 formatting * Adding uri argument * Running with api context * Add wait to ensure that running * Wrong redis pypi package name * Adding list build command to debug tests * Adding auth and non auth tests * Downloading more things * Adding build_artifacts to the api * Update api specification * Timing to ensure that caching is being used * Adding documentation * Remove vale commit b78c64e Author: Chris Ostrouchov <[email protected]> Date: Fri Jun 24 19:19:55 2022 -0400 Adding release check to tests. Bump version 0.4.3 commit 8979df7 Author: Chris Ostrouchov <[email protected]> Date: Fri Jun 24 19:03:40 2022 -0400 Bump version to 0.4.2 commit 11f76f0 Author: Chris Ostrouchov <[email protected]> Date: Fri Jun 24 18:10:46 2022 -0400 Bump version to 0.4.1 commit fbfa678 Author: Christopher Ostrouchov <[email protected]> Date: Fri Jun 24 17:41:36 2022 -0400 Conda-Store client (#327) * Initial commit towards creating a conda-store client * Working client library allong with run execution * Black and Flake8 formatting * Flake8 and Black conda-store-server * Remove parts of cli interface that have not been discussed * Adding documentation around commands commit 10b67ab Author: Christopher Ostrouchov <[email protected]> Date: Tue Jun 21 14:51:03 2022 -0400 Adding searchbar for environments (#326) commit d1dc260 Author: Chris Ostrouchov <[email protected]> Date: Tue Jun 21 10:26:30 2022 -0400 Fixing base api endpoint for openapi documentation commit 9e942e7 Author: Chris Ostrouchov <[email protected]> Date: Tue Jun 21 10:17:08 2022 -0400 Update docs to reflect current version and ownership commit cee6fe0 Author: Chris Ostrouchov <[email protected]> Date: Tue Jun 21 09:55:31 2022 -0400 Create a dedicated section in documentation on REST API commit 52a14db Author: Chris Ostrouchov <[email protected]> Date: Tue Jun 21 09:41:17 2022 -0400 Remove conda-store-ui since it has moved to another repo commit 1ce38dc Author: Christopher Ostrouchov <[email protected]> Date: Tue Jun 21 09:37:59 2022 -0400 Added namespace query parameter to /api/v1/environment/?namespace=... (#324) Closes #323 commit 3e4c84a Author: Peyton Murray <[email protected]> Date: Mon Jun 20 08:12:38 2022 -0700 Add POSTGRES_USER env var back into docker example (#320) commit 13e6db9 Author: telamonian <[email protected]> Date: Wed Jun 15 08:40:09 2022 -0400 cleanup commit f98a04f Merge: 0083077 2413f3f Author: Max Klein <[email protected]> Date: Wed Jun 15 08:28:03 2022 -0400 Merge pull request #284 from telamonian/add-react-ui Add react UI skeleton commit 2413f3f Author: telamonian <[email protected]> Date: Wed Jun 15 08:23:55 2022 -0400 basic redux setup for conda-store-ui commit 0083077 Author: Christopher Ostrouchov <[email protected]> Date: Thu Jun 2 08:58:30 2022 -0400 Redirect login to home page instead of user page (#316) * Redirect login to home page instead of user page * Change UI test since login no longer redirects to user page commit 6acce7c Author: telamonian <[email protected]> Date: Sat May 14 23:11:22 2022 -0400 mostly functional version of package picker ui. still needs bugfixes commit 39f1c44 Author: telamonian <[email protected]> Date: Wed Apr 13 23:18:26 2022 -0400 cleanup of initial prototype code commit fd3a99e Author: telamonian <[email protected]> Date: Wed Apr 13 23:16:44 2022 -0400 rough prototype of react package picker ui done - run with ``` cd conda-store-ui yarn && yarn start ``` commit a339f7e Author: telamonian <[email protected]> Date: Wed Apr 13 20:56:17 2022 -0400 initial work on react ui prototype in conda-store-ui * remove old redis stuff from before it was added * Fix API endpoint `/build/{build_id}/packages` * alembic script split CondaPackage ➞ Package/Build * black * linting * fix /package/ api endpoint * remove old redis stuff from before it was added * adding CondaPackageBuild.channel_id * Split Package/Build : impact * black * Split Package/Build : migrate data * black * Split Package/Build : migrate data improved * linting * fix typo * Fix FK constraints names * Fix DB migration for corner case of dup packages * downgrade migration * cleanup and logs instead of prints * linting * New DB schema png + update eralchemy command * original version of the DB architecture diagram * moving file out of _static * fixing typo * new DB architecture diagram * cleanup * update in changelog * Changelog will be updated when doing the release * Use lockfile when redis is not used + cleanup * got tricked by black * fix migration for sqlite * Fix number of packages shown on page /build/N * Fix downgrade migration for sqlite * linting * update comment * linting Co-authored-by: Christopher Ostrouchov <[email protected]> Co-authored-by: Harsh Mishra <[email protected]> Co-authored-by: gabalafou <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jonzeper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
We are now dependant on the rest api