-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Cannot edit/delete conda-environment after creating if 'default' or 'filesystem' namespaces are chosen. #1158
Comments
@dharhas we probably need to talk about https://github.com/Quansight/qhub/blob/main/qhub/template/stages/07-kubernetes-services/modules/kubernetes/services/conda-store/config/conda_store_config.py#L74-L99. This mainly has to do with how I have the user's setup with group <-> role mappings would be my guess. I've worked on the conda-store ui for a better error message in conda-incubator/conda-store#261. So the user will no longer see the
And will instead see a red banner message that the operation was not permitted. |
@costrouc Part of the issue is that if I have the ability to create an environment in a namespace, I should also have the ability to edit & delete it. I can create envs in defaults and filesystem but I can't edit and delete them. Overall maybe we do this:
Actually now that I think about it, a better model might be:
|
Is this still an issue after all the conda-store work done over the last few months? @costrouc |
Don't think so, closing as out-of-context with recent updates in conda-store |
OS system and architecture in which you are running QHub
GCP
Expected behavior
The conda-store flask interface lets me pick from several namespaces:
I created a new environment via the conda-store flask interface and picked the
default
namespace. I am now unable to edit that environment. I get the error msg:I am also unable to delete it, hitting delete, redirects me to the main jupyterhub home page (i.e. https://quansight-beta.qhub.dev/hub/home) and navigating back to conda-store shows me that the environment hasn't been deleted.
Actual behavior
A couple of options here.
First of all the 'filesystem' namespace should be hidden as an option since I assume this is meant to cover environments created from yaml files on a filesystem somewhere. In addition, I should not be able to create an environment in this namespace via the flask app.
What is the purpose of the 'Default' namespace? Are these environments coming from the git repo or is it something different. If it is mean to be a readonly environment I should not have the ability to create environments in this namespace and it should be hidden as an option as well.
How to Reproduce the problem?
default
offilesystem
as the namespaceCommand output
No response
Versions and dependencies used.
So is there a way to get the QHub version? I don't think it is displayed anywhere.
Compute environment
GCP
Integrations
conda-store
Anything else?
No response
The text was updated successfully, but these errors were encountered: