Fixing docker registry implementation in conda-store (#368)

conda-store-server/conda_store_server/app.py

@@ -256,8 +256,8 @@ def _default_celery_results_backend(self):
     )
 
     default_docker_base_image = Unicode(
-        "frolvlad/alpine-glibc:latest",
-        help="default base image used for the Dockerized environments",
+        "library/debian:sid-slim",
+        help="default base image used for the Dockerized environments. Make sure to have a proper glibc within image.",
         config=True,
     )
 

conda-store-server/conda_store_server/schema.py

@@ -14,7 +14,7 @@ def _datetime_factory(offset: datetime.timedelta):
 
 # namespace and name cannot contain "*" ":" "#" " " "/"
 # this is a more restrictive list
-ALLOWED_CHARACTERS = "A-Za-z0-9-+_=@$&?^|~."
+ALLOWED_CHARACTERS = "A-Za-z0-9-+_@$&?^~.="
 ARN_ALLOWED = f"^([{ALLOWED_CHARACTERS}*]+)/([{ALLOWED_CHARACTERS}*]+)$"
 
 

conda-store-server/conda_store_server/server/views/registry.py

@@ -50,8 +50,8 @@ def replace_words(s, words):
 
     # TODO: should really be doing checking on package names to
     # validate user input
-    packages = [replace_words(_, constraint_mapper) for _ in sorted(packages)]
-    environment_name = "|".join(packages)
+    package_specs = [replace_words(_, constraint_mapper) for _ in sorted(packages)]
+    environment_name = "-".join(packages)
     environment = api.get_environment(
         conda_store.db, environment_name, namespace="conda-store-dynamic"
     )
@@ -60,7 +60,7 @@ def replace_words(s, words):
         environment_specification = {
             "name": environment_name,
             "channels": ["conda-forge"],
-            "dependencies": packages,
+            "dependencies": package_specs,
         }
         conda_store.register_environment(
             environment_specification, namespace="conda-store-dynamic"
@@ -128,7 +128,7 @@ def v2():
     return _json_response({})
 
 
-@router_registry.get("/v2/<rest:path>")
+@router_registry.get("/v2/{rest:path}")
 def list_tags(
     rest: str,
     conda_store=Depends(dependencies.get_conda_store),

conda-store-server/environment-dev.yaml

@@ -4,7 +4,7 @@ channels:
 dependencies:
   # conda builds
   - conda
-  - conda-docker
+  - conda-docker >= 0.1.1
   - conda-pack
   - conda-lock >=1.0.5
   # web server

conda-store-server/environment.yaml

@@ -4,7 +4,7 @@ channels:
 dependencies:
   # conda environment builds
   - conda
-  - conda-docker
+  - conda-docker >= 0.1.1
   - conda-pack
   - conda-lock >=1.0.5
   # web server

docs/administration.md

@@ -219,7 +219,7 @@ docker builds of Conda environments. This package at a minimum should
 have the [following packages
 installed](https://docs.anaconda.com/anaconda/install/linux/). Often
 times for non-graphic and non-gpu environments glibc is enough. Hence
-the default docker image `frolvlad/alpine-glibc:latest`.
+the default docker image `library/debian:sid-slim`.
 
 `CondaStore.serialize_builds` no longer build Conda environment in
 parallel. This is due to an issue in Conda/Mamba that when downloading