Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming with defaults #7

Closed
pelson opened this issue Jul 1, 2016 · 13 comments
Closed

Inconsistent naming with defaults #7

pelson opened this issue Jul 1, 2016 · 13 comments

Comments

@pelson
Copy link
Member

pelson commented Jul 1, 2016

@msarahan & @kalefranz - please be aware that conda-forge packaged ruamel.yaml several months ago and it appears that you guys have recently added it to defaults, but with an inconsistent name ruamel_yaml. In the interests of maintaining consistent naming schemes (currently a requirement to ensure we don't blow different versions over the top of one another) would you be willing to consider renaming your package? If it means anything, it is worth noting that the name that you have chosen in defaults is inconsistent with the experience on pip also.

Thanks!

@jakirkham
Copy link
Member

Friendly nudge @msarahan and @kalefranz.

@msarahan
Copy link
Member

msarahan commented Jul 5, 2016

Sadly, they are different packages. Here's a bit of history: https://bitbucket.org/ruamel/yaml/issues/28/consider-making-ruamelyaml-available-as-a

ruamel_yaml is a version that Continuum modified to not be a namespace package. Its source is at https://bitbucket.org/kalefranz/yaml - the recipe is at https://github.com/ContinuumIO/anaconda-recipes/blob/master/ruamel_yaml/meta.yaml

@jakirkham
Copy link
Member

jakirkham commented Jul 5, 2016

So what you are saying is you Continuum forked ruamel.yaml and renamed it to ruamel_yaml? Is that correct?

@msarahan
Copy link
Member

msarahan commented Jul 5, 2016

"you" being Continuum, not me personally, yes.

@jakirkham
Copy link
Member

Yes, that's what I meant.

@jakirkham
Copy link
Member

Morale of the story is this can be closed as they are different packages and so should not interfere, right?

@msarahan
Copy link
Member

msarahan commented Jul 5, 2016

Yes, I think that they are sufficiently different to not collide. Import names are different and all that. I'm OK closing this if you all are. Otherwise, you probably need to discuss this with @kalefranz

@pelson
Copy link
Member Author

pelson commented Jul 7, 2016

A surprising decision - I have previously looked at the ruamel.yaml codebase, and I wouldn't have been comfortable taking on that maintenance burden (it gets deep quick)...

In anycase, thanks for the info.

@pelson pelson closed this as completed Jul 7, 2016
@scw
Copy link

scw commented Mar 31, 2017

Would bubbling up the two packages in the README of the respective feedstocks be useful? I was working on rebuilding ruamel_yaml, but accidentally instead got into ruamel.yaml, and it wasn't immediately obvious to me why it lacked the internals I was expecting.

@jakirkham
Copy link
Member

Sorry what do you mean by bubbling up?

@scw
Copy link

scw commented Apr 1, 2017

@jakirkham Sorry, that wasn't clear -- just some text clarifying the two packages, and their different provenance. One practical difference (besides the namespace) is that the ruamel_yaml package pulls in the related yaml.dll and builds a PYD to referencing it, the ruamel.yaml build is pure Python.

@eferreira
Copy link

Seems like this issue was deleted so the link is dead now: https://bitbucket.org/ruamel/yaml/issues/28/consider-making-ruamelyaml-available-as-a

@kalefranz or anyone else, do you remember the general gist of what the discussion over there was about? I'm struggling with the confusion between ruamel.yaml and ruamel_yaml now (earlier I was installing it via pip, but I'm trying to install it via conda instead). This is on python 2.7 btw.

I can see that when ruamel.yaml installs via pip, it puts itself into site-packages/ruamel/yaml/ and puts a .pth file into site-packages/. What was the fundamental reason why this same file structure didn't work as a conda package?

Are people just supposed to change their downstream code to import ruamel_yaml instead of ruamel.yaml? I'd like my downstream code to be agnostic to conda installation vs pip installation so I guess I'd have to do some conditional imports? Or am I misunderstanding something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants