Use pypi as source #65
Conversation
Project has moved from bitbucket to sourceforge, but will always be on pypi
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally. |
|
Given what it says in conda-forge/ruamel.yaml-feedstock#7 (and #1), is this the right resolution for this issue? Should it actually be tracking some Anaconda Inc repo? |
…nda-forge-pinning 2020.02.12
recipe/meta.yaml
Outdated
| {% set version = "0.15.80" %} | ||
|
|
||
| package: | ||
| name: ruamel_yaml | ||
| name: {{ name | lower | replace(".", "_") }} |
There was a problem hiding this comment.
Is this actually a different package then?
There was a problem hiding this comment.
As I understand it, this is a mirror of the Anaconda Inc fork (ruamel_yaml) of the upstream project (ruamel.yaml). I'll hard-code the conda package name, but the upstream package is "ruamel.yaml".
There was a problem hiding this comment.
Right, but there is a separate ruamel.yaml package & feedstock for that
There was a problem hiding this comment.
Right. But there's also a ruamel_yaml package that's based on the same upstream Python code.
There was a problem hiding this comment.
To be honest, I made this PR before I understood anything about the difference between the two packages, but now I wonder whether to give up on the "ruamel_yaml" package entirely.
There was a problem hiding this comment.
Yeah, I think giving up on one of them is the right move, and I think it is this one.
| @@ -1,17 +1,18 @@ | |||
| {% set name = "ruamel.yaml" %} | |||
There was a problem hiding this comment.
There is already a ruamel.yaml package
There was a problem hiding this comment.
This doesn't set the name of the package.
It just sets a variable that's used in the source/url templates.
There was a problem hiding this comment.
Yes, but you use the same source as another package that is already on conda-forge. If that is really the case, this whole recipe should just be an alias package instead
There was a problem hiding this comment.
This is just a fix for #64, so that this package can start updating again. There's a whole different discussion about whether this package should exist or not:
There was a problem hiding this comment.
I think those are very coupled conversations
There was a problem hiding this comment.
How so? Surely. if it exists (which it does) then it's better to update it, so that bug and security fixes can be included.
Besides, as I understand it from conda-forge/ruamel.yaml-feedstock#7 (Specifically conda-forge/ruamel.yaml-feedstock#7 (comment)), this package is supposed to be different from the ruamel.yaml package (via patches), even if it's the same upstream source.
There was a problem hiding this comment.
Is this builds exactly the same source as another feedstock, then why should both of them exist?
There was a problem hiding this comment.
Because this version has patches (I think) so it's not exactly the same (I think)
Or is there an option to remove it?
There was a problem hiding this comment.
But you are getting the source from the other package here I thought, which is why I was confused
There was a problem hiding this comment.
Given #64, would it be better to just use the sourceforge repo as the new source?
|
@conda-forge-admin, please rerender |
|
I'm going to withdraw this since it's not going anywhere. |
Project has moved from bitbucket to sourceforge, but will always be on pypi
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #64