avoid conflicting pip package name with ruamel.yaml #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2020.08.17.20.01.55
pip package normalization makes ruamel_yaml and ruamel.yaml equivalent, so `pip install ruamel.yaml` will not install the real package if `ruamel_yaml` is installed. Add `_conda_fork` to the package name to avoid this problem.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruamel_yamlandruamel.yamlare equivalent names, according to pip package normalization.The result is that while
ruamel_yamlis notruamel.yamland can coexist as conda packages,pip install ruamel.yamlwill consider the dependency already satisfied byruamel_yamlif it is present, when it should not.The fix is to use a package name in setup.py that avoids such a collision.
Since this is a conda-only fork, I went with adding
_conda, lacking a more obvious choice.The alternative fix is to remove any pip metadata from the package, but it wasn't obvious how to robustly avoid pip noticing that the package is present.
Related to #1 and conda-forge/ruamel.yaml-feedstock#7