libprotobuf 4.22.3 #144
Merged
libprotobuf 4.22.3 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31bcbc1.
…nda-forge-pinning 2023.02.06.13.55.07
h-vetinari
requested review from
dopplershift,
hajapy,
jakirkham,
ocefpaf,
wesm,
xhochy and
xylar
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This was referenced Feb 7, 2023
…nda-forge-pinning 2023.02.16.23.42.32
|
It seems the tests depend on an abseil target that's not packaged because it's marked TESTONLY. |
5 tasks
|
This now depends on conda-forge/abseil-cpp-feedstock#58, which depends on (something like) conda-forge/gtest-feedstock#69 |
also documented as such in the upstream documentation: https://github.com/protocolbuffers/protobuf/blob/main/cmake/README.md#testing
This was referenced May 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there are rc's for 22.0, which has a major version bump for C++, see https://github.com/protocolbuffers/protobuf/blob/main/version.json
Also, libprotobuf now depends on abseil, which will make life harder in several ways, and will probably require conda-forge/abseil-cpp-feedstock#53.
Finally, we're reinstating the switch to CMake-only on unix (see #68 / #128 / #130), because autotools was dropped completely.
Closes #68
Closes #145
Closes #146
Closes #147
Closes #148