-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Dprotobuf_ABSL_PROVIDER="package"
not fully functional yet
#11828
Comments
This sounds like you have an older version of Abseil installed on your machine. We require at least https://github.com/abseil/abseil-cpp/releases/tag/20230125.0 |
Where is this version requirement documented? |
Our protobuf_deps.bzl file is the SOT for our dependencies |
Does it have to be that exact commit or can it be a range of versions? |
That commit corresponds to the 20230125.2 release. Anything later than that is likely to work, but if it's not an LTS release then Abseil's cmake install will be disabled. This will result in our install setup being broken without some extra cmake flags to bypass it |
This "protobuf only supports one version of abseil-cpp" thing is getting tricky to manage. The latest release of onnxruntime requires protobuf, but it also requires abseil-cpp 20240116.0+. But the latest release of protobuf requires abseil-cpp 20230802.1. Does that mean that it isn't possible to install the latest version of onnxruntime? Or that everyone should just figure out their own range of compatible versions? |
Between 21.12 and 22.0, protobuf gained a dependence on abseil, including a possibility to use
-Dprotobuf_ABSL_PROVIDER="package"
.However, adding that to a CMake build invocation does not yet work (from conda-forge/libprotobuf-feedstock#144):
Presumably some places need a
find_package(absl REQUIRED)
behind an if-statement.The text was updated successfully, but these errors were encountered: