-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build test targets; bump to v20230125.2 #58
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Seems the test libs don't get installed by default either... |
ef1dd89
to
8b0e0c1
Compare
0d89c7f
to
f46c573
Compare
I seem to remember that missing aligned alloc cannot be solved with
I also tried setting only MACOSX_SDK_VERSION to 10.13, but the error remains the same. Will now also bump MACOSX_DEPLOYMENT_TARGET (edit: managed to do it only for the test output) |
c33f76d
to
ebf3f1a
Compare
…nda-forge-pinning 2023.05.06.16.29.06
82a0dcf
to
d6bf696
Compare
Otherwise, the build fails with: ``` absl/functional/internal/any_invocable.h:624:28: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer state_.remote.target = ::new T(std::forward<Args>(args)...); ^ ```
@conda-forge/abseil-cpp, this is ready now. It's required to build the new protobuf version, so even though I wasn't particularly motivated to chase down the compilation errors that needed a bunch of patches, it should now be good to go. Does someone want to have a look? 🙃 |
Protobuf wants
absl::scoped_mock_log
to build (with tests, which I'd like to not disable), but abseil declares that as a test-only dep which isn't built by default.Let's build them to unblock conda-forge/libprotobuf-feedstock#144
Closes #57
Closes #55
Closes #48