Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build test targets; bump to v20230125.2 #58

Merged
merged 9 commits into from
May 12, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Apr 19, 2023

Protobuf wants absl::scoped_mock_log to build (with tests, which I'd like to not disable), but abseil declares that as a test-only dep which isn't built by default.

Let's build them to unblock conda-forge/libprotobuf-feedstock#144

Closes #57
Closes #55
Closes #48

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title Testdeps Build test targets Apr 19, 2023
@h-vetinari
Copy link
Member Author

Seems the test libs don't get installed by default either...

@h-vetinari
Copy link
Member Author

h-vetinari commented Apr 27, 2023

I seem to remember that missing aligned alloc cannot be solved with -D_LIBCPP_DISABLE_AVAILABILITY, which I'm already setting here. Or am I missing something @isuruf?

$WORK/absl/functional/internal/any_invocable.h:624:28: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
    state_.remote.target = ::new T(std::forward<Args>(args)...);

I also tried setting only MACOSX_SDK_VERSION to 10.13, but the error remains the same. Will now also bump MACOSX_DEPLOYMENT_TARGET (edit: managed to do it only for the test output)

@h-vetinari h-vetinari force-pushed the testdeps branch 3 times, most recently from c33f76d to ebf3f1a Compare May 8, 2023 03:00
@h-vetinari h-vetinari changed the title Build test targets build test targets; bump to v20230125.2 May 8, 2023
@h-vetinari h-vetinari force-pushed the testdeps branch 2 times, most recently from 82a0dcf to d6bf696 Compare May 8, 2023 04:20
Otherwise, the build fails with:
```
absl/functional/internal/any_invocable.h:624:28: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
    state_.remote.target = ::new T(std::forward<Args>(args)...);
                           ^
```
@h-vetinari
Copy link
Member Author

h-vetinari commented May 8, 2023

@conda-forge/abseil-cpp, this is ready now. It's required to build the new protobuf version, so even though I wasn't particularly motivated to chase down the compilation errors that needed a bunch of patches, it should now be good to go. Does someone want to have a look? 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants