stop recommending --no-cache-dir be used with pip #653
Conversation
The --no-cache-dir argument supressed wheel building when used with pip. This results in egg-info rather than .dist-info metadata directories being created. A local cache directory is provided by conda-build since 3.14.0 which avoid any issues with the global cache directory.
|
See conda/conda-build#3094 for additional discussion on why |
docs/_sources/meta.rst.txt
Outdated
| @@ -356,7 +356,7 @@ Normally Python packages should use this line: | |||
| .. code-block:: yaml | |||
|
|
|||
| build: | |||
| script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv" | |||
| script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed -vvv" | |||
There was a problem hiding this comment.
Can we remove --no-deps and --ignore-installed as well? conda-build sets env variables that does the same thing right?
There was a problem hiding this comment.
Even though I prefer the explicitness of the having the options in there, since they are already in conda-build (and my guess is that they won't remove/change them) I'm +0.5.
|
@jjhelmus - does there need to be something in to conda smithy rerender for this? |
Looks like we could use it in an automated way. Not sure if |
|
Done in conda/conda-build@85d3a97#diff-c61365ff02198f8397cfa6e399b6ef8b |
|
Rerendering could try to replace this. The old install command is not "wrong" and there are edge cases where a non-standard install command is needed. I'm hesitant to recommend that the bot do this automatically or the linter flag other incantation. |
The bot re-renders with conda-smithy so your hesitation applies there too 😄 Are you recommending to leave as-is and change it when a problem happen? |
Fixes up the docs to include an intended change from another PR that was lost (as it changed autogenerated files). xref: conda-forge#653
| @@ -356,7 +356,7 @@ Normally Python packages should use this line: | |||
| .. code-block:: yaml | |||
|
|
|||
| build: | |||
| script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv" | |||
| script: "{{ PYTHON }} -m pip install . -vvv" | |||
There was a problem hiding this comment.
This is unfortunately an autogenerated file and not the source itself. So this didn't show up in the docs. Fixing with PR ( #659 ).
|
So, following the advice in this PR, I removed |
|
I don't think it is installing them. I think it is caching them. If that is what it is doing, then that is expected as Note: |
|
Oh, I see; I noticed the installation and the |
The --no-cache-dir argument supressed wheel building when used with pip. This
results in egg-info rather than .dist-info metadata directories being created.
A local cache directory is provided by conda-build since 3.14.0 which avoid any
issues with the global cache directory.