Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pmda package #6851

Merged
merged 2 commits into from
Oct 25, 2018
Merged

add pmda package #6851

merged 2 commits into from
Oct 25, 2018

Conversation

kain88-de
Copy link
Contributor

This adds the pmda package.

ping @orbeckst and @richardjgowers to say they are OK being maintainers

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pmda) and found it was in an excellent condition.

run:
- python
- dask
- mdanalysis>=0.18.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kain88-de I think we can just use 0.19 now? The package uses the develop branch, but I think that's solved now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use >= 0.19.0

@orbeckst
Copy link

I am happy to be a maintainer.

@richardjgowers
Copy link
Contributor

Looks good, I'll maintain this

Copy link

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- pip
run:
- python
- dask

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this install the dask conda package with bokeh and everything else needed for the bokeh-based visualization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the dask-core if you want the lighter version of the package here.

Copy link

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orbeckst
Copy link

Who is merging this PR?

@kain88-de
Copy link
Contributor Author

@conda-forge/staged-recipes

It would be nice if this package gets merged. We plan a workshop next month that is using it. Thank you

build:
number: 0
skip: True # [win]
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now recommending people to drop the -no-cache-dir but that can be done in the feedstock. Merging...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the example from the staged-repository. Should the example be changed too then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We are still catching up with the changes in the docs. See conda-forge/conda-forge.github.io#653

@ocefpaf ocefpaf merged commit 6ed6877 into conda-forge:master Oct 25, 2018
@kain88-de kain88-de deleted the pmda branch October 25, 2018 17:16
@kain88-de
Copy link
Contributor Author

Thanks @ocefpaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants