-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pmda package #6851
add pmda package #6851
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/pmda/meta.yaml
Outdated
run: | ||
- python | ||
- dask | ||
- mdanalysis>=0.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kain88-de I think we can just use 0.19 now? The package uses the develop branch, but I think that's solved now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use >= 0.19.0
I am happy to be a maintainer. |
Looks good, I'll maintain this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- pip | ||
run: | ||
- python | ||
- dask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this install the dask conda package with bokeh and everything else needed for the bokeh-based visualization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/conda-forge/dask-feedstock/blob/master/recipe/meta.yaml
Those are all dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the dask-core
if you want the lighter version of the package here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Who is merging this PR? |
@conda-forge/staged-recipes It would be nice if this package gets merged. We plan a workshop next month that is using it. Thank you |
build: | ||
number: 0 | ||
skip: True # [win] | ||
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are now recommending people to drop the -no-cache-dir
but that can be done in the feedstock. Merging...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the example from the staged-repository. Should the example be changed too then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. We are still catching up with the changes in the docs. See conda-forge/conda-forge.github.io#653
Thanks @ocefpaf |
This adds the pmda package.
ping @orbeckst and @richardjgowers to say they are OK being maintainers