Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial recipe for snowflake-connector-python 1.6.12 #7008

Merged
merged 5 commits into from
Dec 13, 2018

Conversation

hajapy
Copy link
Contributor

@hajapy hajapy commented Nov 7, 2018

The Snowflake Connector for Python provides an interface for developing Python applications that can connect to Snowflake and perform all standard operations. It provides a programming alternative to developing applications in Java or C/C++ using the Snowflake JDBC or ODBC drivers.

The connector is a native, pure Python package that has no dependencies on JDBC or ODBC.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/snowflake-connector-python) and found some lint.

Here's what I've got...

For recipes/snowflake-connector-python:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [37, 38]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/snowflake-connector-python) and found it was in an excellent condition.

@djsutherland
Copy link
Contributor

djsutherland commented Nov 8, 2018

You can resolve the merge error by force-pushing away 0a3b44d, now that #7009 is merged.

Also, you should probably add entry points for the entry points in setup.py. And you should remove --no-deps --ignore-installed --no-cache-dir from the pip line; --no-cache-dir is actually a bad idea, and conda-build now sets environment variables to do the others. Other than that, the recipe looks good to me.

@hajapy hajapy force-pushed the snowflake_connector_python branch from 0a3b44d to 16f21ac Compare November 8, 2018 13:13
@hajapy
Copy link
Contributor Author

hajapy commented Nov 8, 2018

Regarding those extra args, such as --no-deps, it looks like pip is actually installing the dependencies in the build log without that arg, whereas I want/need the packages to be from conda-forge not pypi.

@djsutherland
Copy link
Contributor

djsutherland commented Nov 8, 2018

I was confused by that too; it doesn't actually install them, but it does cache them kind of wastefully. I'm fine with leaving --no-deps in to avoid that confusion + waste of time downloading, personally.

@hajapy
Copy link
Contributor Author

hajapy commented Nov 8, 2018

Ok, that's very confusing. It also fills the log with so many unnecessary messages making it harder to read the log file.

I still don't know why the build succeeded on travis with --no-deps and failed without it. I'm waiting to see if the latest branch (with --no-deps again) succeeds on travis.

@hajapy
Copy link
Contributor Author

hajapy commented Nov 8, 2018

Ah, so indeed the build passes on travis with --no-deps and fails without it. Any insights as to why that could happen?

@djsutherland
Copy link
Contributor

From the full log, because -vvv makes it waaay too verbose to see anything (we should drop it to -vv or something):

error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: /Users/travis/miniconda/conda-bld/snowflake-connector-python_1541683071515/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.6/site-packages/cryptography/hazmat/bindings/_constant_time.abi3.so (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

This makes me think that you do actually need --no-deps. I can't investigate further right now, but leave it in for now.

@hajapy
Copy link
Contributor Author

hajapy commented Nov 8, 2018

Ok thanks, I've done that and incorporated your other suggestions.

@jakirkham
Copy link
Member

This makes me think that you do actually need --no-deps.

Confirmed. Raised as issue ( conda/conda-build#3254 ) (though used a different recipe).

@hajapy
Copy link
Contributor Author

hajapy commented Nov 9, 2018

@dougalsutherland Is there anything further needed on this PR then?

@hajapy
Copy link
Contributor Author

hajapy commented Nov 19, 2018

@dougalsutherland is this ready?

@hajapy
Copy link
Contributor Author

hajapy commented Dec 13, 2018

@conda-forge/staged-recipes could someone review/merge this?

@scopatz scopatz merged commit 6f445ac into conda-forge:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants