-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dask
/distributed
pinnings to exclude nightlies
#312
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Output of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Charles! 🙏
Had one question below
version >= pkg_resources.parse_version("2021.12.0") and | ||
version < pkg_resources.parse_version("2022.8.0") or | ||
version == pkg_resources.parse_version("2022.8.0") and | ||
record["build_number"] < 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these constraints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The oldest available dask-core
nightlies that we would want to exclude are 2021.12.0a211220
:
https://anaconda.org/dask/dask-core/files?version=2021.12.0a211220
This targets all Dask packages from 2021.12.0
to the older builds of 2022.8.0
. Is there an easier way to target these packages, or do you think we should target more Dask releases?
Thoughts @conda-forge/core? 🙂 |
Adjusts the pinnings of
dask
anddistributed
packages published after Dask nightlies became available to prevent nightly packages from getting installed with stable conda-forge packages; should make thedask-core
anddistributed
pinnings of these packages consistent with the changes made in conda-forge/dask-feedstock#191 and conda-forge/distributed-feedstock#218.cc @jakirkham @jrbourbeau
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)