Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dask/distributed pinnings to exclude nightlies #312

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Update dask/distributed pinnings to exclude nightlies #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions recipe/gen_patch_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,24 @@ def _gen_new_index_per_key(repodata, subdir, index_key):
if pversion < v2022_6_1:
record['depends'].append('tornado <6.2')

if record_name in {"distributed", "dask"}:
version = pkg_resources.parse_version(record["version"])
if (
version >= pkg_resources.parse_version("2021.12.0") and
version < pkg_resources.parse_version("2022.8.0") or
version == pkg_resources.parse_version("2022.8.0") and
record["build_number"] < 2
Comment on lines +636 to +639
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these constraints?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oldest available dask-core nightlies that we would want to exclude are 2021.12.0a211220:

https://anaconda.org/dask/dask-core/files?version=2021.12.0a211220

This targets all Dask packages from 2021.12.0 to the older builds of 2022.8.0. Is there an easier way to target these packages, or do you think we should target more Dask releases?

):
for dep in record["depends"]:
if dep.startswith("dask-core") or dep.startswith("distributed"):
pkg = dep.split()[0]
major_minor_patch = record["version"].split(".")
major_minor_patch[2] = str(int(major_minor_patch[2]) + 1)
next_patch_version = ".".join(major_minor_patch)
_replace_pin(
dep, f"{pkg} >={version},<{next_patch_version}.0a0", record["depends"], record
)

if record_name == 'fastparquet':
# fastparquet >= 0.7.0 requires pandas >= 1.0.0
# This was taken care of by rebuilding the fastparquet=0.7.0 release
Expand Down