-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dask-core
pinning to properly exclude nightlies
#218
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/distributed-feedstock/actions/runs/2868264018. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca! Seems reasonable to me -- @jakirkham do you have a minute to look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca -- will plan to merge this at EOD if no further comments
Have the same feedback as in the other review ( conda-forge/dask-feedstock#191 (review) ). Would suggest we keep this discussion in that thread for now and then apply whatever we decide to both PRs |
@jrbourbeau, could you please take a look at this as well? If this seems reasonable, would like to merge it before we merge the release PR. That way the new release will have the right version constraint to start 🙂 |
As brought up in conda-forge/dask-feedstock#190 (comment), the pinning introduced in #217 accidentally blocked the security backport proposal - tested this new pinning out locally and it seems to work with backports while also blocking nightly packages.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)