Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask-core pinning to properly exclude nightlies #218

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

charlesbluca
Copy link
Member

As brought up in conda-forge/dask-feedstock#190 (comment), the pinning introduced in #217 accidentally blocked the security backport proposal - tested this new pinning out locally and it seems to work with backports while also blocking nightly packages.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@charlesbluca
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/distributed-feedstock/actions/runs/2868264018.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca! Seems reasonable to me -- @jakirkham do you have a minute to look at this?

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca -- will plan to merge this at EOD if no further comments

@jakirkham
Copy link
Member

Have the same feedback as in the other review ( conda-forge/dask-feedstock#191 (review) ). Would suggest we keep this discussion in that thread for now and then apply whatever we decide to both PRs

@jakirkham
Copy link
Member

@jrbourbeau, could you please take a look at this as well?

If this seems reasonable, would like to merge it before we merge the release PR. That way the new release will have the right version constraint to start 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants