Fix zlib packaging on latest conan not renaming binary appropriately

[Sil3ntStorm]

Specify library name and version: zlib/1.2.11

Update the recipe to rename files properly from the utterly stupid names produced by zlib build scripts.
Fixes #8788

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[conan-center-bot]

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

[SpaceIm]

Suggested change

cmake_policy(SET CMP0091 NEW)

useless, conan_basic_setup() takes care of vc runtime regardless of the policy.

[Sil3ntStorm]

Without it the compiler will complain about an undefined /static command line argument and iirc not produce the correct output.

[SpaceIm]

It's a fix for compiler=msvc in profile actually.

[SpaceIm]

Suggested change

	cmake_minimum_required(VERSION 3.15)
	cmake_minimum_required(VERSION 2.8)

2.8 is fine

[Sil3ntStorm]

It's not, due to the cmake_policy requirement, which was added in 3.15 (according to a quick Google search)

[SpaceIm]

I know but conan_basic_setup() should take care of vc runtime regardless of CMP0091 policy. If you bump to 3.15, you don't need to force CMP0091 to NEW anyway because it would be the default behavior.

[SpaceIm]

Well, maybe it's a conan issue.
@memsharded @lasote @czoido, is new msvc compiler type compatible with old CMake helper + conan_basic_setup()? Does it properly define CONAN_LINK_RUNTIME so that conan_set_vs_runtime() can work as expected?

[lasote]

is new msvc compiler type compatible with old CMake helper + conan_basic_setup()?

I would say it was fixed at Conan 1.43.2 (https://github.com/conan-io/conan/pull/10195/files) At this time we are running 1.43.1 here. (soon will be an upgrade to 1.43.3 with some backports from 1.44.1)

[Sil3ntStorm]

It's a fix for compiler=msvc in profile actually.

That's what conan generates.

conan profile new --detect temp
conan profile show temp
[settings]
os=Windows
os_build=Windows
arch=x86_64
arch_build=x86_64
compiler=msvc
compiler.version=193
build_type=Release
[options]
[conf]
[build_requires]
[env]

[ghost]

I detected other pull requests that are modifying zlib/all recipe:

• zlib: fix lib name in CMakeLists directly instead of fragile renaming #10771

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[SSE4]

@FSil3ntStorm there are conflicts, please rebase

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.