zlib: add version 1.2.12

[toge]

Specify library name and version: zlib/1.2.12

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying zlib/all recipe:

• Fix zlib packaging on latest conan not renaming binary appropriately #8789

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[a4z]

I don't think that is wrong, and I hope _WIN32 also exists when using mingw to cross-compile to windows (from Linux).

But all the sudden the file will have a different checksum for the old version in the conan_imports_manifest.txt .

Is it a good idea to change it like that, why not just do exactly the same, and use #if defined(_WIN32) || defined(__MINGW32__) ?

[a4z]

This update fixes a security issue,
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-25032

Given the amount on packages that depend on zlib, it would be nice if that PR would go through, but it fails now the second time and is already some days here, and I can not see why it fails so I do not know how to help.

Any idea how the situation could be improved, can you please help me to help @uilianries or @jgsogo, or anyone else ?

[SpaceIm]

This update fixes a security issue, https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-25032

Given the amount on packages that depend on zlib, it would be nice if that PR would go through, but it fails now the second time and is already some days here, and I can not see why it fails so I do not know how to help.

Any idea how the situation could be improved, can you please help me to help @uilianries or @jgsogo, or anyone else ?

Almost all PR fail in Windows agents since yesterday, I don't think it's specific to this PR.

[conan-center-bot]

All green in build 6 (0fef838317177e0d80a64cc831e987530092663d):

• zlib/1.2.11@:
  All packages built successfully! (All logs)

• zlib/1.2.12@:
  All packages built successfully! (All logs)

[a4z]

Thanks Spaclm for the explaination!

Still would like to know if it's a good idea to change header for the old version for no reason, or if people think it does not matter when the checksums in the imports manifest change

[uilianries]

LGTM

[toge]

@a4z
Thanks for your comment.
As @SpaceIm already explained, I decided to keep the patch for 1.2.11.

As you know, the patched zlib/1.2.11 is already widely used in conan recipes.
I do not want to modify the patched code.