Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: zlib package need to rename library #10242

Closed
wants to merge 1 commit into from

Conversation

hoxnox
Copy link
Contributor

@hoxnox hoxnox commented Apr 11, 2022

On Linux with static compiler there is only zlibstatic.a in package. It causes problems because standard way of linking is -lz. There already exists logic for renaming the lib. But it works only on Windows.

Specify library name and version: zlib all versions

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

On Linux with static compiler there is only zlibstatic.a in package. It
causes problems because standard way of linking is `-lz`. There already
exists logic for renaming the lib. But it works only on Windows.
@SpaceIm
Copy link
Contributor

SpaceIm commented Apr 11, 2022

On Linux with static compiler there is only zlibstatic.a in package. It causes problems because standard way of linking is -lz. There already exists logic for renaming the lib. But it works only on Windows.

What is your profile? Could you open an issue? On Linux, zlib recipe always produce libz.a for static build, it's even in upstream CMakeLists logic, no need to rename files: https://github.com/madler/zlib/blob/v1.2.12/CMakeLists.txt#L202-L204

@ghost
Copy link

ghost commented Apr 11, 2022

I detected other pull requests that are modifying zlib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@hoxnox
Copy link
Contributor Author

hoxnox commented Apr 11, 2022

Sorry. It's my fault. I've got CONAN_CMAKE_SYSTEM_NAME=Generic in the profile.

On Linux with static compiler there is only zlibstatic.a in package. It causes problems because standard way of linking is -lz. There already exists logic for renaming the lib. But it works only on Windows.

What is your profile? Could you open an issue? On Linux, zlib recipe always produce libz.a for static build, it's even in upstream CMakeLists logic, no need to rename files: https://github.com/madler/zlib/blob/v1.2.12/CMakeLists.txt#L202-L204

@hoxnox hoxnox closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants