-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msys2] Bump version and support two profiles approach. #4286
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying msys2/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msys2/20161025: Forced build from source Installing (downloading, building) binaries... |
ERROR: msys2/20161025: Error in build() method, line 64 No idea how you can fix the problem on the build machines :-)
see more at https://www.msys2.org/news/#2020-06-29-new-packagers |
@SSE4 can you please take a look at what's going wrong? |
@jgsogo as I remember, we had a situation when cross-building recipes were incorrectly discarded at the initial stage (export?) which was always done on Linux machine, so recipe incorrectly rejected all the configurations as valid. do you remember that case? |
recipes/msys2/all/conanfile.py
Outdated
def configure(self): | ||
if self.settings.os_build != "Windows": | ||
def validate(self): | ||
if not tools.os_info.is_windows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's probably the line discarding all the packages, because CI initially tries to export recipe on Linux to calculate all possible package IDs
@dmn-star as I remember, CI works in two phases:
the check |
The CI works more or less as described: there is an initial At this moment, all compilations in the CI are native ones, meaning that the machine running the build matches the profiles used for In this recipe, we probably want to check that |
In general, we should avoid any check using platform, os_info,... which are related to the running machine, not to the package being generated.
This comment has been minimized.
This comment has been minimized.
|
This (?) error has also occurred sporadically on my workstation. 7zip/19.00 is more a "download" requirement. msys2/20210105: Applying build-requirement: 7zip/19.00 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failed in build 35:
|
Failed in build 36:
|
Some configurations of 'msys2/20210105' failed in build 37 (
|
Failure in build 38 (
|
- drop version 20161025 - use new conandata.yml format - avoid unnecessary copying
All green in build 39 (
|
@dmn-star finally, green |
if tools.Version(self.version) <= "20161025": | ||
raise ConanInvalidConfiguration("msys2 v.20161025 is no longer supported") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required since the version was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't remove it, you will receive zero packages generated
error for version 20161025
but right now we're not sure these versions make sense at all, as we upgrade them right away, so effectively all the versions are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we are waiting for a decision regarding rolling releases. :-) cc @jgsogo
Hi! We've been talking about I think we all agree that We are not using just The version is misleading because, as said in previous comments, the packages installed by pacman are the ones when the reference was built (and it is built whenever there is a new recipe-revision), not the ones matching the date of the Now we have a hack to workaround the issue about killing pacman, for sure it is something that we should try to avoid. Maybe it is possible to get the pacman's PID for the What's next?
cc/ @danimtb @SSE4 @uilianries |
hi @dmn-star
besides that new details, everything from Javier's previous comment is still valid |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
||
# https://github.com/msys2/MSYS2-packages/issues/1966 | ||
def _kill_pacman(self): | ||
if (self.settings.os == "Windows"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test can be dropped, it is already checked for in validate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pr has fixed its original intentions:
- add new version: 20210105
- support two profiles approach
Modifying the recipe to add rolling releases would make this pr drag on.
It's currently stalled anyways.
@Stale[bot] Remove the label so my bot can pick this up! Will CCI merge a PR that's marked stale? does this require manual intervention? |
* Bump version and support two profiles approach. https://docs.conan.io/en/latest/reference/profiles.html#build-profiles-and-host-profiles * PR 4286: invalid syntax * PR 4286: add new version (20210105) * PR 4286: CR avoid any check which are related to the running machine In general, we should avoid any check using platform, os_info,... which are related to the running machine, not to the package being generated. * PR 4286: try to move the msys2 download into source(.) https://docs.conan.io/en/latest/reference/conanfile/methods.html#source Please read the Note * PR 4286: 7zip -> tools.unzip(.) * PR 4286: install the new keyring # https://www.msys2.org/news/#2020-06-29-new-packagers * PR 4286: skip msys2 v.20161025 * PR 4286: fix invalid syntax * PR 4286: try to kill pacman first * PR 4286: try to kill pacman first on windows only * Revert "PR 4286: try to kill pacman first on windows only" This reverts commit e774845. * Revert "PR 4286: try to kill pacman first" This reverts commit 0048efa. * PR 4286: pac-man workarounds * PR 4286: Always kill all running msys2 processes * PR 4286: remove configure * PR 4286: more kills * PR 4286: add --ask 20 * PR 4286: less kills * PR 4286: skip hook warning * - more logs * - even more logs Signed-off-by: SSE4 <[email protected]> * - wait for the process Signed-off-by: SSE4 <[email protected]> * - it's possible we have several CI jobs which may incorrectly terminate each other with kill pacman Signed-off-by: SSE4 <[email protected]> * - guard to pass export on Linux Signed-off-by: SSE4 <[email protected]> * - typo * - ValueError * - syntax * - don't raise * - move downloads to build - drop version 20161025 - use new conandata.yml format - avoid unnecessary copying Co-authored-by: SSE4 <[email protected]>
* Bump version and support two profiles approach. https://docs.conan.io/en/latest/reference/profiles.html#build-profiles-and-host-profiles * PR 4286: invalid syntax * PR 4286: add new version (20210105) * PR 4286: CR avoid any check which are related to the running machine In general, we should avoid any check using platform, os_info,... which are related to the running machine, not to the package being generated. * PR 4286: try to move the msys2 download into source(.) https://docs.conan.io/en/latest/reference/conanfile/methods.html#source Please read the Note * PR 4286: 7zip -> tools.unzip(.) * PR 4286: install the new keyring # https://www.msys2.org/news/#2020-06-29-new-packagers * PR 4286: skip msys2 v.20161025 * PR 4286: fix invalid syntax * PR 4286: try to kill pacman first * PR 4286: try to kill pacman first on windows only * Revert "PR 4286: try to kill pacman first on windows only" This reverts commit e774845. * Revert "PR 4286: try to kill pacman first" This reverts commit 0048efa. * PR 4286: pac-man workarounds * PR 4286: Always kill all running msys2 processes * PR 4286: remove configure * PR 4286: more kills * PR 4286: add --ask 20 * PR 4286: less kills * PR 4286: skip hook warning * - more logs * - even more logs Signed-off-by: SSE4 <[email protected]> * - wait for the process Signed-off-by: SSE4 <[email protected]> * - it's possible we have several CI jobs which may incorrectly terminate each other with kill pacman Signed-off-by: SSE4 <[email protected]> * - guard to pass export on Linux Signed-off-by: SSE4 <[email protected]> * - typo * - ValueError * - syntax * - don't raise * - move downloads to build - drop version 20161025 - use new conandata.yml format - avoid unnecessary copying Co-authored-by: SSE4 <[email protected]>
* msys2: do not the library directory propagate through * msys2: uninstall pkgconf pkgconf should be provided by conan * use tools.get this is simpler and automatically removes the downloaded file, making the final package slimmer by 80MB * clarify the rolling release status see #4286 * remove arch from conandata only x86_64 is supported anyway * kill pacman in case of error * bump base version * remove workaround not needed anymore, now that the base version is up to date Co-authored-by: Anonymous Maarten <[email protected]>
Fixes #4277
Fixes #4355
Fixes #4066
Related to #4066
#4066 (comment)
Related to #1960
Related to #4301
Add new version: 20210105
https://github.com/msys2/msys2-installer/releases/tag/2021-01-05
Support two profiles approach
https://docs.conan.io/en/latest/reference/profiles.html#build-profiles-and-host-profiles
32-bit MSYS2 no longer supported
Update keys
https://www.msys2.org/news/#2020-06-29-new-packagers
Workarounds for
Specify library name and version: msys2/all
conan-center hook activated.