-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(plugin): v4.0.0 #344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: requires `webpack >= v4.0.0`
…ndencies`) BREAKING CHANGE: requires `webpack >= v4.0.0`
michael-ciniawsky
force-pushed
the
next
branch
from
September 1, 2018 03:43
dd20f5e
to
5f6c7af
Compare
@rynclark 🤔 Seems TravisCI is still working, shoud we temporarily add a travis config back until we get access to CircleCI ? |
@michael-ciniawsky I say we wait for CircleCI, there's only one unit test and it's not a massive one, your call |
michael-ciniawsky
added
status: Approved
and removed
priority: 3 (required)
status: Pending
labels
Sep 1, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.