refactor(karma-webpack): remove compiler legacy code (compiler.plugin)
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanclark
commented
Sep 1, 2018
| @@ -270,7 +233,9 @@ Plugin.prototype.make = function(compilation, callback) { | |||
| let entry = file; | |||
|
|
|||
| if (this.wrapMocha) { | |||
| entry = `${require.resolve('./mocha-env-loader')}?name=${compilation.name}!${entry}`; | |||
| entry = `${require.resolve('./mocha-env-loader')}?name=${ | |||
There was a problem hiding this comment.
Seems prettier wanted to change this line on this commit for some reason..
michael-ciniawsky
changed the title
compiler.plugin)
michael-ciniawsky
approved these changes
Sep 1, 2018
| }); | ||
| compiler.plugin('make', this.make.bind(this)); | ||
| } | ||
| compiler.hooks.thisCompilation.tap(this.plugin, (compilation, params) => { |
There was a problem hiding this comment.
Could you try with using compilation instead of thisCompilation, the latter is an alias if I remember right and will be removed in a feature version of webpack. But it's not important to do this now, I just saw it, so in case it bugs for whatever reason don't bother :)
michael-ciniawsky
changed the title
compiler.plugin)compiler legacy code (compiler.plugin)
michael-ciniawsky
pushed a commit
that referenced
this pull request
Sep 1, 2018
michael-ciniawsky
pushed a commit
that referenced
this pull request
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior?
Remove legacy compiler hook code for
webpack < v4.0.0compatibility.Does this PR introduce a breaking change?