refactor(package): apply webpack-defaults
#340
Conversation
src/index.js
Outdated
| /* | ||
| MIT License http://www.opensource.org/licenses/mit-license.php | ||
| Author Tobias Koppers @sokra | ||
| MIT License http://www.opensource.org/licenses/mit-license.php |
There was a problem hiding this comment.
This can comment can be removed since the LICENSE file is in the repo and we are now using the JS Foundation License (MIT Variant)
.travis.yml
Outdated
| @@ -12,21 +12,21 @@ jobs: | |||
| - &test-latest | |||
There was a problem hiding this comment.
Travis CI is disabled for webpack-contrib as we switched to CircleCI a while ago, the new config is here https://github.com/webpack-contrib/webpack-defaults/tree/master/templates/.circleci. Please remove the .travis.yml and add the CircleCi Config under .circleci/config.yml
package.json
Outdated
| @@ -16,11 +16,7 @@ | |||
| "lint": "eslint --cache src test", | |||
| "clean": "del-cli lib", | |||
| "build": "cross-env NODE_ENV=production babel src -d lib --ignore 'src/**/*.test.js' --copy-files", | |||
| "test": "mocha --compilers js:babel-register --full-trace --check-leaks test/unit", | |||
| "test:integration": "npm run build && karma start --single-run", | |||
| "travis": "npm run test && npm run test:integration", | |||
There was a problem hiding this comment.
For CircleCI to work you will need the following scripts
"ci:lint": "npm run lint"
"ci:test": "npm run test"
package.json
Outdated
| "cross-env": "^5.2.0", | ||
| "del-cli": "^1.1.0", | ||
| "eslint": "^5.4.0", | ||
| "eslint-config-webpack": "^1.2.5", |
There was a problem hiding this comment.
The latest (>= v2.0.0) config is under @webpack-contrib/eslint-config-webpack now
.babelrc
Outdated
| ] | ||
| } | ||
| } | ||
| "presets": ["@babel/preset-env"] |
There was a problem hiding this comment.
Does preset-env read the target from pkg.engines now? Minimium is node >= v6.0.0 in case you need it
michael-ciniawsky
changed the title
scripts and dependencies
src/mocha-env-loader.js
Outdated
| var sourceNode | ||
| var id = this.options.name | ||
| module.exports = function (content, map) { | ||
| this.cacheable(); |
There was a problem hiding this comment.
This is no longer necessary and can be removed as loaders are cached by default since webpack >= v2.0.0
use webpack-defaults, change the tests to jest (and remove unneeded test)
README.md
Outdated
| @@ -1,10 +1,3 @@ | |||
| [![npm][npm]][npm-url] | |||
There was a problem hiding this comment.
Please leave the README as is the template there is not up-to date and will change
|
CircleCI is not setup up here and I can't enable it in the UI (seems missing permissions), I will check out what's going on there... |
package.json
Outdated
| "engines": { | ||
| "node": ">= 6.9.0" | ||
| "node": ">= 6.9.0 <7.0.0 || >= 8.9.0" |
There was a problem hiding this comment.
Relax this to "node": ">= 6" please
michael-ciniawsky
changed the title
scripts and dependencieswebpack-defaults
michael-ciniawsky
added
status: Approved
and removed
pr_action: Rework
priority: 3 (required)
severity: 4 (inconvenient)
status: Pending
labels
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the new behavior?
Refactor the development scripts and update development dependencies.
test:integrationnpm script as it doesn't work and isn't used anywhereDoes this PR introduce a breaking change?