Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support browsers from before 2020 #23

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Support browsers from before 2020 #23

merged 3 commits into from
Dec 20, 2021

Conversation

L3P3
Copy link

@L3P3 L3P3 commented Dec 8, 2021

This change follows coder/code-server#4579

@jsjoeio
Copy link

jsjoeio commented Dec 8, 2021

We'll need to test this to make sure everything works still.

Steps to Test

  1. checkout branch locally with gh pr checkout 23
  2. Follow docs for linking vscode repo locally
  3. Follow docs to create a build
  4. Test build locally

@jsjoeio
Copy link

jsjoeio commented Dec 8, 2021

Hmm...I'm seeing a bunch of type errors. @L3P3 could you test this locally and let me know if you're seeing the same? We might not be able to do this 🤔 (or it might require more work).

[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(86,29): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(1226,24): Type 'HTMLCollection' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(1242,21): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/testing/test/browser/testObjectTree.ts(57,22): Type 'NodeListOf<HTMLElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/test/browser/ui/tree/objectTree.test.ts(223,19): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/views/treeView.ts(1334,27): Type 'DataTransferItemList' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/views/treeView.ts(1338,28): Parameter 'dataValue' implicitly has an 'any' type.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(1570,24): Type 'HTMLCollection' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/files/browser/fileImportExport.ts(113,22): Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/splitview/paneview.ts(587,14): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(120,21): Type 'NodeListOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(255,26): Type 'NodeListOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(437,22): Type 'HTMLCollectionOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/platform/contextkey/browser/contextKeyService.ts(429,69): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(346,75): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/editor/contrib/colorPicker/colorContributions.ts(40,74): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/markdownRenderer.ts(275,21): Type 'HTMLCollectionOf<HTMLImageElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Finished compilation with 17 errors after 206935 ms
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(86,29): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(1226,24): Type 'HTMLCollection' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts(1242,21): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/testing/test/browser/testObjectTree.ts(57,22): Type 'NodeListOf<HTMLElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/test/browser/ui/tree/objectTree.test.ts(223,19): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/views/treeView.ts(1334,27): Type 'DataTransferItemList' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/views/treeView.ts(1338,28): Parameter 'dataValue' implicitly has an 'any' type.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(1570,24): Type 'HTMLCollection' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/workbench/contrib/files/browser/fileImportExport.ts(113,22): Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/splitview/paneview.ts(587,14): Type 'NodeListOf<Element>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(120,21): Type 'NodeListOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(255,26): Type 'NodeListOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/ui/dialog/dialog.ts(437,22): Type 'HTMLCollectionOf<HTMLAnchorElement>' must have a '[Symbol.iterator]()' method that returns an iterator.
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/platform/contextkey/browser/contextKeyService.ts(429,69): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(346,75): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/editor/contrib/colorPicker/colorContributions.ts(40,74): Property 'values' does not exist on type 'DOMTokenList'. Did you mean 'value'?
[15:29:44] Error: /Users/jp/Dev/coder/vscode/src/vs/base/browser/markdownRenderer.ts(275,21): Type 'HTMLCollectionOf<HTMLImageElement>' must have a '[Symbol.iterator]()' method that returns an iterator.

I think we'll hold off on this until after 4.0.0 is released

@jsjoeio
Copy link

jsjoeio commented Dec 9, 2021

@code-asher tested this yesterday and didn't see these same errors. What are you seeing @L3P3? I see you modified the lib. Think that fixed this?

@code-asher
Copy link
Member

code-asher commented Dec 10, 2021

Weirdly I did start seeing the iterator errors the next day so I am not sure what happened 🤷 dom.iterable does seem like it should fix it. We ought to add a build step to the CI here at some point.

@L3P3
Copy link
Author

L3P3 commented Dec 18, 2021

Can it be merged now? The mentioned errors were resolved with the "lib" setting...
The related PR in code-server was merged, I recon.

@code-asher code-asher self-requested a review December 20, 2021 16:18
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping!

@code-asher code-asher merged commit d50b73c into coder:main Dec 20, 2021
jsjoeio added a commit that referenced this pull request Jan 5, 2022
jsjoeio added a commit that referenced this pull request Jan 5, 2022
jsjoeio added a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants