Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support for older browsers (ios 12) #4785

Open
wiegell opened this issue Jan 24, 2022 · 8 comments
Open

[Feat]: Support for older browsers (ios 12) #4785

wiegell opened this issue Jan 24, 2022 · 8 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@wiegell
Copy link

wiegell commented Jan 24, 2022

ES2020 is a showstopper for some older browsers e.g. all IOS 12 devices (original iPad air in my case). Safari chokes on optional chaining (?.)

ES6 compile was tested in coder/vscode#23, but then removed again in #d4f09b4.
Any plans to reinstate ES6?

For other people on ios 12, the latest code-server still on ES6 (before microsoft bumped vscode to ES2020) is [email protected]

@wiegell wiegell added the enhancement Some improvement that isn't a feature label Jan 24, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 24, 2022

I don't think so unfortunately. We did test it but then had to remove it because it broke Jupyter Notebooks. I don't know if there's a solution that doesn't cause something to break. If you ideas though, we'd be open to it

@wiegell
Copy link
Author

wiegell commented Jan 26, 2022

What about an argument for the install script that gives the option of building with ES6?

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 26, 2022

I like the sound of that! But my concern is then we'd be shipping a version of code-server that only partially works since Jupyter Notebooks would be broken. We'd also have to maintain an additional set of binaries, right?

A couple options:

  • I wonder if we could add an option to the install script called "build from source" which could take a config where you could specify "bundle with ES6
  • you could fork code-server, make the changes in your fork and then create a build yourself (easiest, preferred solution)

@wiegell
Copy link
Author

wiegell commented Jan 26, 2022

Option one is the neatest while option two might be the easiest. I think it would be ok with some stuff not working as long as the user is sufficiently warned.
My personal incentive have waned, since i now bought a newer tablet. Maybe the issue should just linger to see if its worth the effort?

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 27, 2022

My personal incentive have waned, since i now bought a newer tablet. Maybe the issue should just linger to see if its worth the effort?

Haha definitely! I'll add it to the Backlog Candidates.

@jsjoeio jsjoeio added this to the Backlog Candidates milestone Jan 27, 2022
@helojo
Copy link

helojo commented Apr 1, 2022

is the same problem? my iPad os version is iOS 13.
when I open the url on the ipad browser, there is no any display, and the screen is always white after input the password.But it's ok on Macos or windows.Has anyone else encountered this problem?

IMG_E9AAAA813D13-1

@wiegell
Copy link
Author

wiegell commented Apr 1, 2022

is the same problem? my iPad os version is iOS 13.

when I open the url on the ipad browser, there is no any display, and the screen is always white after input the password.But it's ok on Macos or windows.Has anyone else encountered this problem?

IMG_E9AAAA813D13-1

As mentioned above - revert to 3.10.2

@helojo
Copy link

helojo commented Apr 1, 2022

As mentioned above - revert to 3.10.2

@wiegell thank you,I will upgrade iOS to 15.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

3 participants