-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter Notebooks not working #3782
Comments
Planning to look into this after we wrap up 3.11! |
FYI It worked fine with code-server 3.10.2 387b12e, Python 2021.5.926500501 and Jupyter 2021.6.832593372. |
I can confirm, the same symptom is occurring running 3.12.0. I am running with node v14.18.0 on ppc64le. |
Please see here! |
Same issue for me with my installation on my iMac with Os X 10.14 using Homebrew (the latest version of code-server is 3.12.0); jupyter files won't open:
Python extension installed (v2021.10.1365161279 from open-vsx) and Jupyter too (v2021.8.12; actually I tried to install a more recent version using open-vsx, the installer said that version 2021.10.100 was succesfully installed code-server shows me the other version). They are no python or jupyter duplicated versions in the extension directory. I can select the python interpreter, also for jupyter server, but when I try to open a .ipynb file I get the following error: The same issue if I run from the iMac where code-server is installed or remotely using my Chromebook. PS (off-topic) adding the suggested lines in prdouct.json to use open-vsx does not seem to work for me even after a server restart:
|
Hi @jsjoeio , thank you very much for your kind reply. |
@adalseno thanks for the quick reply - nope that's exactly right so something is not right! |
Hi @jsjoeio ,I don't know if this can help, but, after uninstalling the extensions and cleaning the extension dir, I tried to download the extensions from vsx and manually install them via command line. I got en error installing the latest version of ms-toolsai since it says it is not compatible with Vscode 1.60.0, see the screenshot: |
Yeah, we're in the process of updating VS Code so it should be compatible in the next release 🤞 (sorry for the issues!) |
Hi @jsjoeio , will it work if, in the meanwhile, I install a previous version of the plugins? And if so which version? Thanks |
Dang it! Thanks for the report.
Yes, you're right :( I don't think brew keeps old versions around. You can install code-server through npm/yarn and use npm. i.e. yarn global add [email protected] |
@fritterhoff The latest release artefacts do not include the fix. |
Ahhhh fu ... I only checked the timestamps and not the commits. Okay nvm. Than I'll wait until the next dev. build. |
@benz0li FYI: I've built my own version - well the extensions work, but some other rather odd effects occure. Prop. you also will recognize the one or the other (strange) behavior. |
So far I figured out at least two issues that are rather strange:
J18wyKZCEB.mp4
W1ybZ8Js3K-conv.mp4Okay seems like I figured out in which situation it works and in which not: If I start code-server using
Maybe that helps? |
Thank you for testing it and nice find! If it works with `?folder` I
think I might know where the problem is. I will take a look soon.
|
Yes, adding the param |
I found this thread after hours of searching on the Internet for the enable-proposed-api problem. And it took another hour to read and understand. Here is what worked for me finally (@jsjoeio's solution #3782 (comment)) :
"enabledApiProposals": [
"notebookConcatTextDocument",
"notebookControllerKind",
"notebookDebugOptions",
"notebookDeprecated",
"notebookEditor",
"notebookEditorDecorationType",
"notebookEditorEdit",
"notebookMessaging",
"notebookMime",
"notebookCellExecutionState",
"portsAttributes",
"textDocumentNotebook",
"quickPickSortByLabel"
], Restart |
@bhatiaabhinav sorry you didn't find this sooner (and sorry for the long read)! Thanks for taking the time to post your quick 3-step solution. Hoping it saves someone else time later! |
@jsjoeio Not working with code-server v4.0.1. Tested with the latest release artefacts. @code-asher Please check with the deployment at https://vscode-r.jupyter.b-data.ch. Output in web console:
|
Jep seeing it finally ... |
Yep. Getting the same error. |
So I'm playing arround with different versions. Until now I can confirm coder/vscode@0e2dc9d is working, the current artifacts are broken and (try and error) attempt using coder/vscode@acfcdb5 also does not work. Atm I'm building a version using coder/vscode@53bc751 so the issue can be isolated to one or two commits ... |
So, it seems like either coder/vscode@53bc751 or coder/vscode@d50b73c causes the issues. As coder/vscode@53bc751 "only" adds a missing file I'm pretty sure, that coder/vscode@d50b73c (coder/vscode#23) causes the issues. Well now it's up to you @code-asher @jsjoeio to dig into that problems and maybe to revert coder/vscode#23? |
@benz0li @fritterhoff wow - thank you both for digging in! @code-asher should we revert coder/vscode@d50b73c then? |
@jsjoeio Atm I'm building a fork of your vscode without that patch and all remaining. So prop. I can tell you in +- 30mins if it works. |
@fritterhoff you rock! I'm running it locally with this revert to ensure it works as expected too! |
That seemed to do it! Thank you again for making this very easy to fix. We couldn't have done it this fast without both of you Screen.Recording.2022-01-05.at.10.23.40.AM.mov |
Sorry a little bit off topic: |
e.g. |
Sorry for posting in a closed thread, but this doesn't appear to be working in the npm install of '4.1.0'. Checking the web browser revealed the same error that you showed above about the ipynbMain.js file missing. I would bet that this is a really simple fix of changing a reference or something for the npm install, but I'm not familiar enough with the codebase to even know where to look. I was able to get around the issue by pulling the compiled version of ipynbMain.js from my install of vscode, and placing it in the location that code-server was looking at. (I also had to create a dist directory for it). Hopefully this gives enough information to help anyone else looking to get around this, as well as helps the maintainer easily resolve this 😄 |
Thank you for reporting!
I verified the ipynb extension is missing the dist directory after
installing (`yarn global add code-server` in my case).
It exists in the standalone release though so I guess it is unlikely to
be a build issue.
I downloaded the npm package artifact from CI but it looks fine so not a
packaging issue either.
Which I guess means something went wrong when we ran `yarn publish`. I
think we will need to try re-publishing, maybe as 4.1.0-1 although I am
nervous the same thing will happen.
|
Interesting, I can run |
OS/Web Information
code-server --version
: 3.11.0 4e8cd09Steps to Reproduce
.ipynb
fileExpected
Jupyter extension should load and display the Jupyter notebook.
Actual
Logs
Log (Remote Extension Host)
Screenshot
See above.
Notes
This issue can be reproduced in VS Code: No
@jsjoeio This is the bug report you asked for in issue #3776.
The text was updated successfully, but these errors were encountered: