Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch isProposedAPIEnabled to always be true #30

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

jsjoeio
Copy link

@jsjoeio jsjoeio commented Dec 16, 2021

This PR patches VS Code to always assume the proposed API is enabled. We were already doing this a9ea411 but for some reason, that change wasn't working with one of the Jupyter versions so we had to patch it here.

This shouldn't cause any regressions or instability as far as we can tell.

H/T to @bryphe-coder who actually found and suggested this patch.

Fixes coder/code-server#3782

@jsjoeio jsjoeio self-assigned this Dec 16, 2021
@jsjoeio jsjoeio merged commit 48507d9 into main Dec 17, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-proposed-api branch December 17, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Notebooks not working
2 participants