Skip to content

Commit

Permalink
Report for issue #206 updated by ArmedGoose
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Jan 28, 2023
1 parent 2517254 commit 66c65ec
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion data/ArmedGoose-Q.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@ Filter special characters, at least <, >, ", ' ideally allow only alphanumeric o

References:
https://github.com/code-423n4/2022-01-timeswap-findings/issues/131
https://securiumsolutions.com/blog/xss-through-svg-file-upload/
https://securiumsolutions.com/blog/xss-through-svg-file-upload/



Issue 2: receipts are not burned upon claiming reward.

In my opinion, current system of just claiming some tokens to be "used" has some downsides:
- in any claim check, users spend gas to iterate over these tokens too etc. there are two loops in only claim function that checks every token of user
- depending on how the front end will be organized, how users on secondary markets will be warned no to buy already claimed receipts? This might be primary vector for scammers

Recommendation: the receipts should be burned upon reward is claimed for them, removing them from the circulating supply. This decreases gas consumption on users side and prevents potential scam attack vectors in the future.

0 comments on commit 66c65ec

Please sign in to comment.