Skip to content

Issues: code-423n4/2023-01-rabbithole-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166 Open 540 Closed
166 Open 540 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

QA Report bug Something isn't working grade-b Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#676 opened Jan 30, 2023 by code423n4
2
QA Report bug Something isn't working grade-b Q-02 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#675 opened Jan 30, 2023 by code423n4
4
QA Report bug Something isn't working grade-b Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#671 opened Jan 30, 2023 by code423n4
2
QA Report bug Something isn't working grade-b Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#670 opened Jan 30, 2023 by code423n4
2
QA Report bug Something isn't working grade-a Q-05 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#669 opened Jan 30, 2023 by code423n4
5
There is no way to revoke a specified signature that is provided but not yet used for minting a RabbitHole receipt bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#663 opened Jan 30, 2023 by code423n4
3
QuestFactory is suspicious of the reorg attack 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working grade-b M-01 satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#661 opened Jan 30, 2023 by code423n4
12
QA Report bug Something isn't working grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#660 opened Jan 30, 2023 by code423n4
2
Users may mint receipts before Quest has started, if there is none or faulty off-chain validation bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-b Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#656 opened Jan 30, 2023 by code423n4
3
QA Report bug Something isn't working edited-by-warden grade-b Q-10 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#654 opened Jan 30, 2023 by code423n4
3
QA Report bug Something isn't working grade-b Q-11 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#653 opened Jan 30, 2023 by code423n4
2
Unlike questFee_ , royaltyFee_ is missing Upper Limit bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#651 opened Jan 30, 2023 by code423n4
3
Gas Optimizations bug Something isn't working edited-by-warden G (Gas Optimization) G-01 grade-b
#650 opened Jan 30, 2023 by code423n4
1
QA Report bug Something isn't working grade-b Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#648 opened Jan 30, 2023 by code423n4
2
Gas Optimizations bug Something isn't working G (Gas Optimization) G-02 grade-b
#647 opened Jan 30, 2023 by code423n4
3
Gas Optimizations bug Something isn't working G (Gas Optimization) G-03 grade-b
#644 opened Jan 30, 2023 by code423n4
1
QA Report bug Something isn't working grade-b Q-08 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#643 opened Jan 30, 2023 by code423n4
3
QA Report bug Something isn't working grade-b Q-14 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#642 opened Jan 30, 2023 by code423n4
2
QA Report bug Something isn't working edited-by-warden grade-b Q-15 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#641 opened Jan 30, 2023 by code423n4
4
Gas Optimizations bug Something isn't working G (Gas Optimization) G-04 grade-b
#640 opened Jan 30, 2023 by code423n4
1
Gas Optimizations bug Something isn't working G (Gas Optimization) G-05 grade-b
#637 opened Jan 30, 2023 by code423n4
1
Royalty logic might result in DoS with certain marketplaces bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue edited-by-warden grade-b Q-16 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#635 opened Jan 30, 2023 by code423n4
3
Incase a malicious attack occurs and the quest is paused, the owner won't be able to withdraw some of his tokens back. bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#634 opened Jan 30, 2023 by code423n4
7
Incompatibility with Rebasing or Deflationary or Inflationary Tokens bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-454 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax satisfactory satisfies C4 submission criteria; eligible for awards sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#630 opened Jan 30, 2023 by code423n4
8
Gas Optimizations bug Something isn't working G (Gas Optimization) G-06 grade-a
#628 opened Jan 30, 2023 by code423n4
1
ProTip! Exclude everything labeled bug with -label:bug.