Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1.0: kvserver: change default for kv.raft_log.loosely_coupled_truncation.e… #80238

Merged
merged 3 commits into from
Apr 21, 2022
Merged

release-22.1.0: kvserver: change default for kv.raft_log.loosely_coupled_truncation.e… #80238

merged 3 commits into from
Apr 21, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 20, 2022 •
edited by sumeerbhola
Loading

Backport 1/1 commits from #80193 on behalf of @sumeerbhola.

/cc @cockroachdb/release

…nabled to false

This is due to the regression noticed in
#78412

Release note: None

Release justification: Fix for performance regression that has been deemed a release blocker.

srosenberg and others added 3 commits April 18, 2022 03:03
@srosenberg
ci: fix optimizer_tests_impl.sh
90d3711 
Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`.
The recent refactoring of optimizer_tests_impl.sh erroneously used
the latter instead of the former.
Consequently, (sql) Optimizer Tests stopped working in CI.

Fixes: #77688
Release justification: ensure CI can run nightly (sql) Optimizer Tests
Release note: None
@srosenberg
Merge pull request #80180 from cockroachdb/blathers/backport-release-…
dc22506 
…22.1.0-80091

release-22.1.0: ci: fix optimizer_tests_impl.sh
@sumeerbhola
kvserver: change default for kv.raft_log.loosely_coupled_truncation.e…
108d71e 
…nabled to false

This is due to the regression noticed in
#78412

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 20, 2022 12:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1.0-80193 branch from cd44647 to 108d71e Compare April 20, 2022 12:55
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 20, 2022 •
edited by sumeerbhola
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 20, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala added the do-not-merge bors won't merge a PR with this label. label Apr 20, 2022
@celiala
Copy link
Collaborator

celiala commented Apr 20, 2022 •
edited
Loading

Hello! FYI - We haven't fast-forwarded the release-22.1.0 to the latest SHA on release-22.1 yet:

tbg
tbg approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the diff, but note Celia's comment.

@celiala celiala changed the base branch from delete-release-22.1.0 to release-22.1.0 April 21, 2022 17:12
@celiala celiala requested a review from a team as a code owner April 21, 2022 17:12
@celiala
Copy link
Collaborator

celiala commented Apr 21, 2022

The https://github.com/cockroachdb/cockroach/tree/release-22.1.0 has been cut, so this backport should be merged onto it

@celiala celiala removed the do-not-merge bors won't merge a PR with this label. label Apr 21, 2022
@sumeerbhola sumeerbhola merged commit b804864 into release-22.1.0 Apr 21, 2022
@sumeerbhola sumeerbhola deleted the blathers/backport-release-22.1.0-80193 branch April 21, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@erikgrinaker erikgrinaker Awaiting requested review from erikgrinaker

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees

@sumeerbhola sumeerbhola

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cockroach-teamcity @celiala @tbg @sumeerbhola @srosenberg