ci: ensure all nightlies post github issues when tests fail #77688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rail
requested changes
Mar 11, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)
build/teamcity/cockroach/nightlies/compose.sh, line 40 at r1 (raw file):
if [ $exit_status -ne 0 ] then exit $exit_status
I think you can just exit $exit_status without the if check, because exit 0 is a normal exit status.
build/teamcity/cockroach/nightlies/lint_urls_impl.sh, line 24 at r1 (raw file):
$GO_TEST_JSON_OUTPUT_FILE \ $exit_status if [ $exit_status -ne 0 ]
the same here
build/teamcity/cockroach/nightlies/random_syntax_tests_impl.sh, line 22 at r1 (raw file):
/artifacts \ $GO_TEST_JSON_OUTPUT_FILE \ $exit_status
you need to add exit here
build/teamcity/cockroach/nightlies/sqlite_logic_test_impl.sh, line 23 at r1 (raw file):
/artifacts \ $GO_TEST_JSON_OUTPUT_FILE \ $exit_status
and here
Release justification: ensure failing nightlies post github issues Release note: None
rickystewart
force-pushed
the
nightlypost
branch
from
cf78893 to
82e0b12
Compare
rail
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:
|
bors r=rail |
|
Build succeeded: |
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Apr 18, 2022
Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`. The recent refactoring of optimizer_tests_impl.sh erroneously used the latter instead of the former. Consequently, (sql) Optimizer Tests stopped working in CI. Fixes: cockroachdb#77688 Release justification: ensure CI can run nightly (sql) Optimizer Tests Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
80091: ci: fix optimizer_tests_impl.sh r=srosenberg a=srosenberg Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`. The recent refactoring of optimizer_tests_impl.sh erroneously used the latter instead of the former. Consequently, (sql) Optimizer Tests stopped working in CI. Fixes: #77688 Release justification: ensure CI can run nightly (sql) Optimizer Tests Release note: None 80130: ci: fail if `redact_safe.md` is not up-to-date r=rail,ajwerner a=rickystewart Release note: None 80135: bazel: bump size of `rangefeed` test r=celiala a=rickystewart I've seen this time out in CI a couple times. Release note: None Co-authored-by: Stan Rosenberg <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`. The recent refactoring of optimizer_tests_impl.sh erroneously used the latter instead of the former. Consequently, (sql) Optimizer Tests stopped working in CI. Fixes: #77688 Release justification: ensure CI can run nightly (sql) Optimizer Tests Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`. The recent refactoring of optimizer_tests_impl.sh erroneously used the latter instead of the former. Consequently, (sql) Optimizer Tests stopped working in CI. Fixes: #77688 Release justification: ensure CI can run nightly (sql) Optimizer Tests Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: ensure failing nightlies post github issues
Release note: None