Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1.0: ci: fix optimizer_tests_impl.sh #80180

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 19, 2022

Backport 1/1 commits from #80091 on behalf of @srosenberg.

/cc @cockroachdb/release


Confusingly bazci uses --artifacts_dir whereas roachtest uses --artifacts.
The recent refactoring of optimizer_tests_impl.sh erroneously used
the latter instead of the former.
Consequently, (sql) Optimizer Tests stopped working in CI.

Fixes: #77688
Release justification: ensure CI can run nightly (sql) Optimizer Tests
Release note: None


Release justification:

Confusingly bazci uses `--artifacts_dir` whereas roachtest uses `--artifacts`.
The recent refactoring of optimizer_tests_impl.sh erroneously used
the latter instead of the former.
Consequently, (sql) Optimizer Tests stopped working in CI.

Fixes: #77688
Release justification: ensure CI can run nightly (sql) Optimizer Tests
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 19, 2022 16:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1.0-80091 branch from ed99c71 to 90d3711 Compare April 19, 2022 16:48
@blathers-crl blathers-crl bot requested review from mgartner and rickystewart April 19, 2022 16:48
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 19, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 19, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg merged commit dc22506 into release-22.1.0 Apr 19, 2022
@srosenberg srosenberg deleted the blathers/backport-release-22.1.0-80091 branch April 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants