Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: make enable_implicit_transaction_for_batch_statements false by default #77973

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 16, 2022

fixes #77967

Release justification: low risk setting change to preserve pre-22.1
behavior.

Release note (sql change): The
enable_implicit_transaction_for_batch_statements session variable now
defaults to false.

@rafiss rafiss requested review from ajwerner and a team March 16, 2022 20:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@rafiss rafiss changed the title sql: make enable_implicit_transaction_for_batch_statements false by default release-22.1: sql: make enable_implicit_transaction_for_batch_statements false by default Mar 16, 2022
…efault

Release justification: low risk setting change to preserve pre-22.1
behavior.

Release note (sql change): The
enable_implicit_transaction_for_batch_statements session variable now
defaults to false.
@rafiss rafiss force-pushed the disable-enable_implicit_transaction_for_batch_statements branch from 8e57cf1 to ff02940 Compare March 17, 2022 02:40
@rafiss rafiss requested a review from a team March 17, 2022 02:40
@rafiss rafiss requested review from a team as code owners March 17, 2022 02:40
@rafiss rafiss requested review from dt and removed request for a team March 17, 2022 02:40
@rafiss rafiss merged commit 2d49a7b into cockroachdb:release-22.1 Mar 17, 2022
@rafiss rafiss deleted the disable-enable_implicit_transaction_for_batch_statements branch March 23, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants