Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: make enable_implicit_transaction_for_batch_statements false by default; or false for DDL #77967

Closed
rafiss opened this issue Mar 16, 2022 · 0 comments
Closed

release-22.1: make enable_implicit_transaction_for_batch_statements false by default; or false for DDL #77967

rafiss opened this issue Mar 16, 2022 · 0 comments
Assignees
@rafiss
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker

Comments

@rafiss
Copy link
Collaborator

rafiss commented Mar 16, 2022 •
edited by cockroach-jira-scripts
Loading

The new enable_implicit_transaction_for_batch_statements session var defaults to true. This is a bug fix, but the change can cause pain since we have differing behavior for schema changes inside or outside a transaction.

To ease the transition, we should make v22.1 default the setting to false. Or we can be a bit more aggressive and set it to true, but keep the old behavior if schema changes, BACKUP, RESTORE, or IMPORT are involved.

Jira issue: CRDB-13876
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 labels Mar 16, 2022
@rafiss rafiss self-assigned this Mar 16, 2022
@rafiss rafiss mentioned this issue Mar 16, 2022
Merged
@rafiss rafiss closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafiss