sql: make enable_implicit_transaction_for_batch_statements false by d…

…efault Release justification: low risk setting change to preserve pre-22.1 behavior. Release note (sql change): The enable_implicit_transaction_for_batch_statements session variable now defaults to false.
cockroachdb · Mar 16, 2022 · 8e57cf1 · 8e57cf1
1 parent 761e08e
commit 8e57cf1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/cmd/roachtest/tests/asyncpg_blocklist.go b/pkg/cmd/roachtest/tests/asyncpg_blocklist.go
@@ -147,6 +147,7 @@ var asyncpgBlocklist21_2 = blocklist{
 	"test_copy.TestCopyTo.test_copy_records_to_table_async":                                               "unknown",
 	"test_copy.TestCopyTo.test_copy_to_table_basics":                                                      "unknown",
 	"test_cursor.TestCursor.test_cursor_02":                                                               "unknown",
+	"test_cursor.TestCursor.test_cursor_03":                                                               "unknown",
 	"test_cursor.TestCursor.test_cursor_04":                                                               "unknown",
 	"test_cursor.TestIterableCursor.test_cursor_iterable_02":                                              "unknown",
 	"test_exceptions.TestExceptions.test_exceptions_str":                                                  "unknown",
@@ -180,6 +181,7 @@ var asyncpgBlocklist21_2 = blocklist{
 	"test_pool.TestPool.test_pool_init_race":                                                              "unknown",
 	"test_pool.TestPool.test_pool_init_run_until_complete":                                                "unknown",
 	"test_pool.TestPool.test_pool_remote_close":                                                           "unknown",
+	"test_pool.TestPool.test_pool_11":                                                                     "unknown",
 	"test_prepare.TestPrepare.test_prepare_06_interrupted_close":                                          "unknown",
 	"test_prepare.TestPrepare.test_prepare_08_big_result":                                                 "unknown",
 	"test_prepare.TestPrepare.test_prepare_09_raise_error":                                                "unknown",

diff --git a/pkg/sql/vars.go b/pkg/sql/vars.go
@@ -1988,7 +1988,7 @@ var varGen = map[string]sessionVar{
 		Get: func(evalCtx *extendedEvalContext) (string, error) {
 			return formatBoolAsPostgresSetting(evalCtx.SessionData().EnableImplicitTransactionForBatchStatements), nil
 		},
-		GlobalDefault: globalTrue,
+		GlobalDefault: globalFalse,
 	},
 }