release-20.2: sql: fix reg* cast escaping #58030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (bug fix): Fix a bug where casts to regclass were not escaped (i.e. when the type or table name had " characters).
|
This change is |
Release note (sql change): Added ability to cast a string containing all integers to be cast into a given regtype, e.g. '1234'::regproc is now valid. Release note (bug fix): Fixed a bug where casts from string to regproc, regtype or regprocedure would not work if they contained " characters at the beginning or at the end.
rafiss
force-pushed
the
backport20.2-55607
branch
from
27bf5ac to
5f2388d
Compare
|
This fix looks somewhat involved so I want to better understand the severity of the bug so we can make a call about the risk. Is the main reason for backporting this to support TypeORM? Is it newly broken in 20.2? Do we know if TypeORM will be well-supported once this bug is fixed? |
|
I didn't backport this for the reason above, i.e. it is a high risk change which was already a bug before 20.2... |
|
My bad, I thought this broke TypeORM starting in 20.2 since I misread #57971. But this is new behavior in TypeORM (typeorm/typeorm@bc623a4#diff-3af60f660db25bba92d1aadb6b0d86dfad4cc1e4f0061f8b767b66c3c512b05d) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #55607.
/cc @cockroachdb/release
fixes #57971
see #57559 for an explanation of the changed logic test output for "char"
Resolves #53686
tree: add more casting fixes for text to reg*
Release note (sql change): Added ability to cast a string containing all
integers to be cast into a given regtype, e.g. '1234'::regproc is now
valid.
Release note (bug fix): Fixed a bug where casts from string to regproc,
regtype or regprocedure would not work if they contained " characters at
the beginning or at the end.
sql: fix unescaped casts to regclass types
Release note (bug fix): Fix a bug where casts to
regclass were not escaped (i.e. when the
type or table name had " characters).