Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: missing backport to 20.2 related to "char" #57559

Closed
knz opened this issue Dec 4, 2020 · 4 comments
Closed

sql: missing backport to 20.2 related to "char" #57559

knz opened this issue Dec 4, 2020 · 4 comments
Assignees
Labels
A-sql-typing SQLtype inference, typing rules, type compatibility. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Dec 4, 2020

In 20.2:

[email protected]:58180/defaultdb> select '"char"'::regtype;
   regtype
-------------
  character
(1 row)

On master and psql:

[email protected]:26257/defaultdb> select '"char"'::regtype;
  regtype
-----------
  "char"
(1 row)

There was a PR that fixed that but it's not backported yet. Found while working on #57558.

@knz knz assigned rafiss and otan Dec 4, 2020
@blathers-crl
Copy link

blathers-crl bot commented Dec 4, 2020

Hi @knz, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@knz knz changed the title sql: missing backport to 20.2 sql: missing backport to 20.2 related to "char" Dec 4, 2020
@knz knz added A-sql-typing SQLtype inference, typing rules, type compatibility. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Dec 4, 2020
@rafiss
Copy link
Collaborator

rafiss commented Dec 4, 2020

Thanks for finding this. I haven't looked at the code yet, but pretty sure it's this: #55607. also, #56298 happened recently and might be related but is a bigger change. @otan i think #55607 can be backported but not sure about #56298 -- what do you think?

@otan
Copy link
Contributor

otan commented Dec 4, 2020

Yeah they need some backports which I wasn't looking to do in 20.2 since they're mildly risky...
Seems like behavior for a long time as well.

@otan
Copy link
Contributor

otan commented Dec 6, 2020

i'm closing this because this is a longstanding bug, which i don't think is urgent enough to backport to 20.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-typing SQLtype inference, typing rules, type compatibility. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

3 participants