pgwire: rework DecodeOidDatum to DecodeDatum to parse OidFamily types #56298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
parse_oid
branch
4 times, most recently
from
4c367f4 to
d9b38b9
Compare
rafiss
reviewed
Nov 16, 2020
There was a problem hiding this comment.
lgtm after fixing the comment. nice refactor ^_^
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan and @rafiss)
pkg/sql/pgwire/pgwirebase/encoding.go, line 300 at r2 (raw file):
If res is nil
nit: need to update comment since res is gone
rafiss
reviewed
Nov 16, 2020
| @@ -203,77 +203,3 @@ func TestTupleCastVolatility(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestCastStringToRegClassTableName(t *testing.T) { | |||
There was a problem hiding this comment.
oh just noticed, where did this test go?
There was a problem hiding this comment.
pkg/sql/sem/tree/datum_test.go
* Move ParseDOid and associated methods to new function. * Move datum_test.go to datum_integration_test.go, as it does not import datum.go tests. * Move some of datum_invariants_test.go out into datum_test.go. * Created new datum_test.go with pure unit tests. Release note: None
Reworked DecodeOidDatum to DecodeDatum to take in a type, which encodes additional useful information necessary for ENUMs and oid family types. Release note (bug fix): Fixed a bug where reg* types were not parsed properly over pgwire, COPY or prepared statements.
rafiss
approved these changes
Nov 23, 2020
|
bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56193
pgwire: rework DecodeOidDatum to DecodeDatum to parse OidFamily types
Reworked DecodeOidDatum to DecodeDatum to take in a type, which
encodes additional useful information necessary for ENUMs and oid
family types.
Release note (bug fix): Fixed a bug where reg* types were not parsed
properly over pgwire, COPY or prepared statements.
tree: create ParseDOid method
datum.go tests.
Release note: None