Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix reg* cast escaping #55607

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Oct 15, 2020

Resolves #53686


tree: add more casting fixes for text to reg*

Release note (sql change): Added ability to cast a string containing all
integers to be cast into a given regtype, e.g. '1234'::regproc is now
valid.

Release note (bug fix): Fixed a bug where casts from string to regproc,
regtype or regprocedure would not work if they contained " characters at
the beginning or at the end.

sql: fix unescaped casts to regclass types

Release note (bug fix): Fix a bug where casts to
regclass were not escaped (i.e. when the
type or table name had " characters).

Release note (bug fix): Fix a bug where casts to
regclass were not escaped (i.e. when the
type or table name had " characters).
@otan otan requested review from rafiss and a team October 15, 2020 16:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (sql change): Added ability to cast a string containing all
integers to be cast into a given regtype, e.g. '1234'::regproc is now
valid.

Release note (bug fix): Fixed a bug where casts from string to regproc,
regtype or regprocedure would not work if they contained " characters at
the beginning or at the end.
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! i enjoyed reading the splitIdentifierList impl

@otan
Copy link
Contributor Author

otan commented Oct 19, 2020

awesome! i enjoyed reading the splitIdentifierList impl

not sure if serious :P

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Oct 19, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: incorrect syntax error message when escaping a quote in table name
3 participants